Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(response): assert expected column presence for empty result #165

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

SlowMo24
Copy link
Collaborator

@SlowMo24 SlowMo24 commented Aug 1, 2024

No description provided.

@SlowMo24 SlowMo24 self-assigned this Aug 1, 2024
Copy link
Contributor

@matthiasschaub matthiasschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add two more test case covering that explode_tags is empty and None

ohsome/response.py Show resolved Hide resolved
@SlowMo24
Copy link
Collaborator Author

SlowMo24 commented Aug 7, 2024

@SlowMo24 SlowMo24 requested a review from matthiasschaub August 7, 2024 16:35
@SlowMo24 SlowMo24 merged commit af13807 into master Sep 2, 2024
4 checks passed
@SlowMo24 SlowMo24 deleted the assert_column_presence_if_empty branch September 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants