Merge pull request #835 from GIScience/831-swagger-error

fix: invalid example GeoJSON in swagger Co-authored-by: Matthias Merdes <[email protected]>
GIScience · Oct 10, 2024 · d0cce02 · d0cce02
2 parents 4708033 + df6b2ce
commit d0cce02
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,10 +8,13 @@
 
 ### Bug Fixes
 
+- fix: invalid example GeoJSON in swagger ([#831])
 - fix: global coverage is now returned correctly ([#821])
 
 
 [#821]: https://github.com/GIScience/ohsome-quality-api/issues/821
+[#831]: https://github.com/GIScience/ohsome-quality-api/issues/831
+[#832]: https://github.com/GIScience/ohsome-quality-api/issues/832
 
 
 ## Release  1.5.0

diff --git a/ohsome_quality_api/api/request_models.py b/ohsome_quality_api/api/request_models.py
@@ -41,7 +41,8 @@ class BaseBpolys(BaseConfig):
                             ]
                         ],
                     },
-                },
+                    "properties": {},
+                }
             ],
         }
     )

diff --git a/regression-tests/roads_polygon_attributecompleteness.hurl b/regression-tests/roads_polygon_attributecompleteness.hurl
@@ -13,7 +13,7 @@ bytes count > 1900
 
 jsonpath "$.result[0].metadata.name" == "Attribute Completeness"
 jsonpath "$.result[0].topic.name" == "Roads"
-jsonpath "$.result[0].result.description" contains "The ratio of the features (all: 1034299.9) compared to features with expected tags (matched: 276785.2) is 0.27."
+jsonpath "$.result[0].result.description" contains "The ratio of the features (all: 1034408.4) compared to features with expected tags (matched: 278118.2) is 0.27. Around 25-75% of the features match the expected tags."
 jsonpath "$.result[0].result.figure.data[0].gauge.steps[0].color" == "tomato"
 jsonpath "$.result[0].result.label" == "yellow"
 

diff --git a/regression-tests/roads_polygon_mappingsaturation.hurl b/regression-tests/roads_polygon_mappingsaturation.hurl
@@ -12,7 +12,7 @@ status == 200
 bytes count > 24000
 
 jsonpath "$.result[0].topic.name" == "Roads"
-jsonpath "$.result[0].result.description" contains "The saturation of the last 3 years is 98.3%.High saturation has been reached (97% < Saturation ≤ 100%)."
+jsonpath "$.result[0].result.description" contains "The saturation of the last 3 years is 98.46%.High saturation has been reached (97% < Saturation ≤ 100%)."
 jsonpath "$.result[0].result.figure.data[0].line.color" == "#2185D0"
 jsonpath "$.result[0].result.label" == "green"
-Original file line number
+Diff line change
@@ Expand Up / @@ -41,7 +41,8 @@ class BaseBpolys(BaseConfig): @@
                                 ]
                             ],
                         },
-                    },
+                        "properties": {},
+                    }
                 ],
             }
         )
@@ Expand Down @@