Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/avoid area generation #399

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

TheGreatRefrigerator
Copy link
Collaborator

No description provided.

as the disaster ors plugin adds polygons with holes to the map
and the avoid areas currently collect all existing polygons,
area generation fails as the polygon with hole can't be transformed
to GeoJSON properly.
This simple check will ensure that the polygons with holes will
be skipped.

Efforts to put the avoid areas in their own layer group were
fruitless so far, as the L.Control.Draw requires them to be
present directly in the map overlay pane.
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@TheGreatRefrigerator
Copy link
Collaborator Author

  • Docker image has been failing for a while already (and not really needed for now, as config still not switched to env vars)
  • SonarCloud has issues with function complexity which should be resolved outside the hot-fix

@TheGreatRefrigerator TheGreatRefrigerator merged commit be52527 into main Sep 25, 2023
@TheGreatRefrigerator TheGreatRefrigerator deleted the fix/avoid-area-generation branch September 25, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant