Feat/extra info refactor #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
TheGreatRefrigerator
force-pushed
the
feat/extra-info-refactor
branch
from
7f5eaf0 to
0bab51e
Compare
|
simplify method to use array of lat and lng values instead of objects.
when an alternative route was selected and the routes recalculated, the UI would keep the activeRouteIndex. It is now reset to the first route instead which is the normal route.
when using alternative routes, the selected extra information was lost when switching the active route. The selected extra is now saved in the store and displayed when the active route changes.
when switching between alternative routes, the extra info section is now expanded if some extra info is currently displayed on the map.
when selecting an alternative route via map or the button in the route details, the active route would change but the details would not be expanded. The panel that should be expanded is now set from the, activeRouteIndex in the store. - avoid collapsing again for button in the route details
TheGreatRefrigerator
force-pushed
the
feat/extra-info-refactor
branch
from
0bab51e to
dbbaa51
Compare
|
blackbirdem
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the usability of the extra info toggle and makes it working properly with alternative routes.
The state of the extra info visibility is now stored and reused for subsequent and alternative routes.
This works for extra info sub categories as well (e.g. waytype=highway).
If the selected/new route doesn't have that sub category, it falls back to the main extra info category (e.g. from displaying waytype=highway to waytype)
Fixes two small issues:
Includes small refactoring.