Fix/usability issues #456
Merged
Fix/usability issues #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hide sidebar on click only for low resolution as it doesn't make sense on larger screens - adjust showMapViewClickPopups to split between 'med & high' vs 'low' instead of 'high' vs 'low & med' if a right-click was done within 2 seconds after adding the first point, show click popups would still be false, due to this dubious async logic that is now removed. The logic somehow prevented to show the "What's this" modal, which without it came up when clicking an alternative route. This is prevented by stopping the propagation to the map base layer in alternativeRouteIndexSelected.
after the refactoring of the extra info, it was only calculated once during creation of the route-extras component. It is now also calculated on route changes. Moving the map also triggers a route change but value doesn't change, which is treated within the watch handler.
e.g. map attribution
|
This was
linked to
issues
Aug 23, 2024
Closed
|
Sonar Cloud duplication can be ignored, as these are css color entries & labels needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.