Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "emphasized" to menu item options #3225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

garrettjstevens
Copy link
Collaborator

This is another idea that came about while trying to figure out how to handle #3199, but has utility outside that application so I'm making it a separate PR.

This proposes adding an "emphasized" property to menu items. If true, the menu item has a red "badge" next to it. Menu open buttons can also look to see if they have emphasized items and add a badge as well. This PR adds that support for the top-level menus and track menus:

image
image

This is what the menu items themselves look like:

image
image

If a submenu contains an emphasized item, it also has a badge. Also note, the menu itself has no logic for removing the emphasis when e.g. the menu item is clicked on, that will have to be handled by whatever adds the menu item.

It could also be called "alerted" or "badged" (since it uses the Badge component) instead of "emphasized."

One use case I see for this is that when a plugin is added, any new menus or menu items it adds could be emphasized, to help users know where to look for those new actions.

@garrettjstevens garrettjstevens self-assigned this Sep 27, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 27, 2022
@rbuels rbuels added enhancement New feature or request discuss in meeting and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 28, 2022
@garrettjstevens garrettjstevens marked this pull request as ready for review September 29, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants