fix : generic 사용하여 중복 제거 #7

GO-SOPT-ANDROID · May 17, 2023 · 0662d0e · 0662d0e
1 parent be59f3f
commit 0662d0e
Show file tree

Hide file tree

Showing 7 changed files with 40 additions and 41 deletions.
diff --git a/app/src/main/java/org/android/go/sopt/data/remote/model/BaseResponseDto.kt b/app/src/main/java/org/android/go/sopt/data/remote/model/BaseResponseDto.kt
@@ -0,0 +1,15 @@
+package org.android.go.sopt.data.remote.model
+
+import kotlinx.serialization.SerialName
+import kotlinx.serialization.Serializable
+
+
+@Serializable
+data class BaseResponseDto<T>(
+    @SerialName("status")
+    val status: Int,
+    @SerialName("message")
+    val message: String,
+    @SerialName("data")
+    val data: T? = null
+)
diff --git a/app/src/main/java/org/android/go/sopt/data/remote/model/SignInDto.kt b/app/src/main/java/org/android/go/sopt/data/remote/model/SignInDto.kt
@@ -13,20 +13,10 @@ data class RequestSignInDto(
 
 @Serializable
 data class ResponseSignInDto(
-    @SerialName("status")
-    val status: Int,
-    @SerialName("message")
-    val message: String,
-    @SerialName("data")
-    val data: SignInData
-){
-    @Serializable
-    data class SignInData(
-        @SerialName("id")
-        val id: String,
-        @SerialName("name")
-        val name: String,
-        @SerialName("skill")
-        val skill: String
-    )
-}
+    @SerialName("id")
+    val id: String,
+    @SerialName("name")
+    val name: String,
+    @SerialName("skill")
+    val skill: String
+)
diff --git a/app/src/main/java/org/android/go/sopt/data/remote/model/SignUpDto.kt b/app/src/main/java/org/android/go/sopt/data/remote/model/SignUpDto.kt
@@ -17,18 +17,8 @@ data class RequestSignUpDto(
 
 @Serializable
 data class ResponseSignUpDto(
-    @SerialName("status")
-    val status: Int,
-    @SerialName("message")
-    val message: String,
-    @SerialName("data")
-    val data: SignUpData,
-){
-    @Serializable
-    data class SignUpData(
-        @SerialName("name")
-        val name: String,
-        @SerialName("skill")
-        val skill: String,
-    )
-}
+    @SerialName("name")
+    val name: String,
+    @SerialName("skill")
+    val skill: String,
+)
diff --git a/app/src/main/java/org/android/go/sopt/data/remote/service/SignInService.kt b/app/src/main/java/org/android/go/sopt/data/remote/service/SignInService.kt
@@ -1,5 +1,6 @@
 package org.android.go.sopt.data.remote.service
 
+import org.android.go.sopt.data.remote.model.BaseResponseDto
 import org.android.go.sopt.data.remote.model.RequestSignInDto
 import org.android.go.sopt.data.remote.model.ResponseSignInDto
 import retrofit2.Call
@@ -11,5 +12,5 @@ interface SignInService {
     fun signIn(
         @Body
         request: RequestSignInDto,
-    ): Call<ResponseSignInDto>
+    ): Call<BaseResponseDto<ResponseSignInDto>>
 }
diff --git a/app/src/main/java/org/android/go/sopt/data/remote/service/SignUpService.kt b/app/src/main/java/org/android/go/sopt/data/remote/service/SignUpService.kt
@@ -1,5 +1,6 @@
 package org.android.go.sopt.data.remote.service
 
+import org.android.go.sopt.data.remote.model.BaseResponseDto
 import org.android.go.sopt.data.remote.model.RequestSignUpDto
 import org.android.go.sopt.data.remote.model.ResponseSignUpDto
 import retrofit2.Call
@@ -12,5 +13,5 @@ interface SignUpService {
     fun signUp(
         @Body
         request: RequestSignUpDto,
-    ): Call<ResponseSignUpDto>
+    ): Call<BaseResponseDto<ResponseSignUpDto>>
 }
diff --git a/app/src/main/java/org/android/go/sopt/presentation/login/LoginActivity.kt b/app/src/main/java/org/android/go/sopt/presentation/login/LoginActivity.kt
@@ -12,6 +12,7 @@ import org.android.go.sopt.presentation.signup.SignUpActivity
 import org.android.go.sopt.databinding.ActivityLoginBinding
 import org.android.go.sopt.SoptApplication
 import org.android.go.sopt.data.remote.ServicePool
+import org.android.go.sopt.data.remote.model.BaseResponseDto
 import org.android.go.sopt.data.remote.model.RequestSignInDto
 import org.android.go.sopt.data.remote.model.ResponseSignInDto
 import org.android.go.sopt.data.remote.service.SignInService
@@ -46,10 +47,10 @@ class LoginActivity : AppCompatActivity() {
                         etMainId.text.toString(),
                         etMainPassword.text.toString(),
                     )
-                ).enqueue(object : retrofit2.Callback<ResponseSignInDto> {
+                ).enqueue(object : retrofit2.Callback<BaseResponseDto<ResponseSignInDto>> {
                     override fun onResponse(
-                        call: Call<ResponseSignInDto>,
-                        response: Response<ResponseSignInDto>
+                        call: Call<BaseResponseDto<ResponseSignInDto>>,
+                        response: Response<BaseResponseDto<ResponseSignInDto>>
                     ) {
                         if (response.isSuccessful) {
                             SoptApplication.prefs.setBoolean(KEY_ISLOGIN, true)
@@ -62,7 +63,7 @@ class LoginActivity : AppCompatActivity() {
                         }
                     }
 
-                    override fun onFailure(call: Call<ResponseSignInDto>, t: Throwable) {
+                    override fun onFailure(call: Call<BaseResponseDto<ResponseSignInDto>>, t: Throwable) {
                         t.message?.let { showShortToast(it) }
                     }
                 })

diff --git a/app/src/main/java/org/android/go/sopt/presentation/signup/SignUpActivity.kt b/app/src/main/java/org/android/go/sopt/presentation/signup/SignUpActivity.kt
@@ -11,6 +11,7 @@ import org.android.go.sopt.data.local.User
 import org.android.go.sopt.databinding.ActivitySignUpBinding
 import org.android.go.sopt.SoptApplication
 import org.android.go.sopt.data.remote.ServicePool
+import org.android.go.sopt.data.remote.model.BaseResponseDto
 import org.android.go.sopt.data.remote.model.RequestSignUpDto
 import org.android.go.sopt.data.remote.model.ResponseSignUpDto
 import org.android.go.sopt.presentation.login.LoginActivity
@@ -46,9 +47,9 @@ class SignUpActivity : AppCompatActivity() {
                         etSignupName.text.toString(),
                         etSignupSpecialty.text.toString()
                     )
-                ).enqueue(object : retrofit2.Callback<ResponseSignUpDto> {
+                ).enqueue(object : retrofit2.Callback<BaseResponseDto<ResponseSignUpDto>> {
                     override fun onResponse(
-                        call: Call<ResponseSignUpDto>, response: Response<ResponseSignUpDto>
+                        call: Call<BaseResponseDto<ResponseSignUpDto>>, response: Response<BaseResponseDto<ResponseSignUpDto>>
                     ) {
                         if (response.isSuccessful) {
                             response.body()?.message?.let { showShortToast(it) }
@@ -61,7 +62,7 @@ class SignUpActivity : AppCompatActivity() {
                         }
                     }
 
-                    override fun onFailure(call: Call<ResponseSignUpDto>, t: Throwable) {
+                    override fun onFailure(call: Call<BaseResponseDto<ResponseSignUpDto>>, t: Throwable) {
                         t.message?.let { showShortToast(it) }
                     }