Week1 필수과제 #1
Merged
Week1 필수과제 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeonHwan-Kim
requested review from
daehwan2da,
Bewheneverwhatiwant and
Sangwook123
daehwan2da
suggested changes
Apr 8, 2023
| if (id == binding.etMainId.text.toString() && password == binding.etMainPassword.text.toString()) { | ||
| val intent = Intent(this, MainActivity::class.java) | ||
| intent.putExtra("name", name) | ||
| intent.putExtra("specialty", specialty) |
There was a problem hiding this comment.
여기서 "name", "specialty" 와 같은 부분은 매직리터럴이라고 합니다~
만약 MainActivity 에서 intent 로 부터 담긴 value 를 꺼내올때 key 에 오타가 있으면 컴파일 시점에는 잡히지 않는데,
런타임 시점에서는 버그로 발생되어지겠죵?
| val name = binding.etSignupName.text | ||
| val specialty = binding.etSignupSpecialty.text | ||
|
|
||
| if(id.length !in 6..10){ |
There was a problem hiding this comment.
이런 if, else 처리는 개인적으로 코틀린 스럽지 않다고 생각되어지고요..
이런거 해결하는 방법들을 코틀린스럽게 에서 알려줄게요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
필수과제 수행
심화 과제
도전 과제
부족한 부분