GPII-2395: XRandR bridge should provide all posible screen resolutions #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified the node XRandR add-on to return the available screen resolutions as an array of JSON objects, rather than strings. - Refactored the XRandR bridge code into a fluid component. - Updated the unit tests in light of the above.
|
CI job passed. |
Modified "screen-resolution" payload to now contain: - "current-resolution" (width and height) - "available-resolution" (array of widths and heights).
|
CI job passed. |
Modified to be analagous to the Windows display settings handler.
|
CI job passed. |
|
CI job passed. |
Remvoed {that} parameter from get() and set() functions.
|
CI job passed. |
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
|
ok to test |
|
CI job passed. |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/linux-tests/133/ |
|
CI job passed: https://ci.gpii.net/job/linux-tests/135/ |
|
CI job passed: https://ci.gpii.net/job/linux-tests/141/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/linux-tests/143/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/linux-tests/149/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/linux-tests/156/ |
Includes updating to latest master branch.
|
CI job passed: https://ci.gpii.net/job/linux-tests/160/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@javihernandez, @kaspermarkus Here are changes to the Linux/GNOME XRandR bridge to provide all possible screen resolutions when asked.
I went a little further than just modifying the node add-on and the bridge to provide this information. I also refactored the bridge into a fluid component. It was previously a set of namespaced functions -- a number of
fluid.defaults()each with a grade of"fluid.function". Now those functions are invokers within agpii.xrandrfluid component.One issue, though: @javihernandez, I'm not clear what the
gpii.xrandr.allSettingsconstruct at line 93 is for. I couldn't see where it was actually used outside of the XRandR bridge. I kept it, and its use inside the bridge, but couldn't actually fit it into the newgpii.xrandrcomponent.Anyhow, let me know what you think.