Fixed embree compilation errors due to the rework of ray masking. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapes and rays now have specific methods to set the mask for use with embree.
Some improvements to the code to make use of C++11+ features (override, range-based for loops).
A lot of warnings were being generated by the VS2017 compiler with the previous version.
|
Would someone be able to post the log of the build checker? The build works fine for me on Windows with VS2017. |
|
Okay, I just got around to building the branch with my changes on my Linux VM (Ubuntu 18.04.1 LTS with g++ 7.3.0) and the build worked fine. Thus, I would appreciate any info that can help me find the cause for the continuous-integration test failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as @jerumble had mentioned in his comment in the thread of my last pull request, I accidentally broke the compilation if the Embree backend was enabled.
These commits fix this issue by adding the required methods and functions to enable users to use geometry masking in Embree once again.
I furthermore updated the Google Test framework to the latest version (v.1.8.1) as the old version was generating a lot of warnings.
I'd love to hear what you think, and if you have any feedback or would like something changed, please let me know.
Cheers,
Sebastian