Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out of counter splitting if group max is zero #70

Merged

Commits on Jan 6, 2023

  1. Error out of counter splitting if group max is zero

    A counter group having a counter max of zero is invalid and
    will ultimately result in a hang when we try to split counters
    into multiple passes. This is one of various scenarios that
    result in a hang during counter splitting; see
    
     GPUOpen-Tools#69
    
    This fixes only that specific scenario. We now check that the
    group max isn't zero, and if it is, we give up trying to split
    a public counter's HW counters into multiple passes. We log
    an error, too.
    
    Again, this isn't a comprehensive fix for issue 69. There could
    be other cases of bad data that result in a hang. Issue 69 should
    be fixed with a pass cap limit to cover all cases. But this
    commit still adds value in that it flags the specific invalid GPU
    counter metadata in addition to avoiding the hang.
    
    Change-Id: I56d7d2043ba92c1b6088f0fdd68f5ec844e7b823
    jcortell68 committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    798d7ab View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Address code review comments

    Fixed constant name and log statement
    jcortell68 committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    fe012c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Adjust error messages

    Also added missing GPA_ENUM_STRING_VAL for new error code
    jcortell68 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    3118bfd View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    05617a7 View commit details
    Browse the repository at this point in the history