Remove context manager #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebulaval
added a commit
that referenced
this pull request
Jun 23, 2024
* bump black version * Improve documentation (#211) * fix error in documentation and improve it * add api.rst documentation file * update chabngelog * fix disk memory usage problem with some github actions * add disk space cleaning for disk space errors * delete windows cleaning since use unix command * Add Training Guides (#212) and Improve Doc * fix error in documentation and improve it * add api.rst documentation file * first draft of training_guidelines * removed installation and getting started from index to specific files for easier redability * added training guide & fixed warnings * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * Update docs/source/training_guide.rst * fix header error * clean spacing * clean spacing README * added details about the data * changed countries names to english * Update docs/source/training_guide.rst Co-authored-by: David Beauchemin <[email protected]> * Update docs/source/training_guide.rst Co-authored-by: David Beauchemin <[email protected]> * formatting - removed blanck line * Update docs/source/training_guide.rst --------- Co-authored-by: Marouane Yassine <[email protected]> Co-authored-by: Marouane Yassine <[email protected]> * improve documentation * bump black version * improve documentation * Bump black from 23.9.1 to 24.3.0 (#218) * Update CODE_OF_CONDUCT.md * Bump black from 23.9.1 to 24.3.0 Bumps [black](https://github.com/psf/black) from 23.9.1 to 24.3.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@23.9.1...24.3.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * pyproject.toml * fix black * fix requirements --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: David Beauchemin <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix fastapi security RDoS breach * Improve data validation (#227) * fix typos in documentation * fix pylint * fix black version and black * fix errors in tests * remove fixed version * fix app * fix pylint disable * fix pylint disable * correction in changelog and added stuff for this PR * Remove context manager (#228) * fix imports * add interface for data cleaning pre processing during loading * add interface for data cleaning pre processing during loading * Bpemb hot fix (#229) * hot-fix the problem with BPEmb broken base URL * add changelog * bump version to 0.9.10 * fix numpy due to makor release breaking change * fix numpy due to makor release breaking change * fix numpy due to makor release breaking change * fix tests with new bpemb wrapper * fix tests with new bpemb wrapper * remove unecessary tests * fix app tests * fix app tests * fix app circular import * fix sentry deprecated argument * Fix typos in changelog --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Marouane Yassine <[email protected]> Co-authored-by: Marouane Yassine <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #226.
It adds an argument to the
DatasetContainerinterface to use a pre-processing data cleaning function before validation.