Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bpemb hot fix #229

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Bpemb hot fix #229

merged 3 commits into from
Jun 23, 2024

Conversation

davebulaval
Copy link
Collaborator

This PR fixe issue #221.

It use a simplistic wrapper around BPEmb to fix the base URL and resolved download problem.

@davebulaval davebulaval merged commit 166bf28 into dev Jun 23, 2024
19 of 42 checks passed
@davebulaval davebulaval deleted the bpemb-hot-fix branch June 23, 2024 21:43
davebulaval added a commit that referenced this pull request Jun 23, 2024
* bump black version

* Improve documentation (#211)

* fix error in documentation and improve it

* add api.rst documentation file

* update chabngelog

* fix disk memory usage problem with some github actions

* add disk space cleaning for disk space errors

* delete windows cleaning since use unix command

* Add Training Guides (#212) and Improve Doc

* fix error in documentation and improve it

* add api.rst documentation file

* first draft of training_guidelines

* removed installation and getting started from index to specific files for easier redability

* added training guide & fixed warnings

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* Update docs/source/training_guide.rst

* fix header error

* clean spacing

* clean spacing README

* added details about the data

* changed countries names to english

* Update docs/source/training_guide.rst

Co-authored-by: David Beauchemin <[email protected]>

* Update docs/source/training_guide.rst

Co-authored-by: David Beauchemin <[email protected]>

* formatting - removed blanck line

* Update docs/source/training_guide.rst

---------

Co-authored-by: Marouane Yassine <[email protected]>
Co-authored-by: Marouane Yassine <[email protected]>

* improve documentation

* bump black version

* improve documentation

* Bump black from 23.9.1 to 24.3.0 (#218)

* Update CODE_OF_CONDUCT.md

* Bump black from 23.9.1 to 24.3.0

Bumps [black](https://github.com/psf/black) from 23.9.1 to 24.3.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@23.9.1...24.3.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* pyproject.toml

* fix black

* fix requirements

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: David Beauchemin <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix fastapi security RDoS breach

* Improve data validation (#227)

* fix typos in documentation

* fix pylint

* fix black version and black

* fix errors in tests

* remove fixed version

* fix app

* fix pylint disable

* fix pylint disable

* correction in changelog and added stuff for this PR

* Remove context manager (#228)

* fix imports

* add interface for data cleaning pre processing during loading

* add interface for data cleaning pre processing during loading

* Bpemb hot fix (#229)

* hot-fix the problem with BPEmb broken base URL

* add changelog

* bump version to 0.9.10

* fix numpy due to makor release breaking change

* fix numpy due to makor release breaking change

* fix numpy due to makor release breaking change

* fix tests with new bpemb wrapper

* fix tests with new bpemb wrapper

* remove unecessary tests

* fix app tests

* fix app tests

* fix app circular import

* fix sentry deprecated argument

* Fix typos in changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Marouane Yassine <[email protected]>
Co-authored-by: Marouane Yassine <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant