Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[200] Build Manage Evaluators List #243
[200] Build Manage Evaluators List #243
Changes from 39 commits
589d27f
8f3fa45
84f3b13
12c95ff
89fedc4
4f48437
3335e3f
b18a5af
f13edf1
74ebbfc
25fc5b6
32dbc51
0453855
6bd9cf3
888d2ae
e4b10f7
2eaf379
333a590
296a0fe
f25eb6d
f587d15
2a17abd
219095e
db6e2a7
ffb623d
aaa1c69
1764e7e
f77730f
adc6422
98bb679
d23da73
b9364aa
b725416
667cb62
9f3d3af
c1cb69c
a630bb9
5e7eb94
de375d6
32e3205
0f60b7c
a56ba86
f15ffad
86c9b6f
4fe4a1b
13a08bc
73af9de
13dbc4c
a30de58
15405e0
7cecef3
4064d4f
0df811a
380c7ce
b13b54f
e41dd2b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this before_action is overloaded with several routes and conditionals. I'm not sure how each route will work.
before_action
s should be simple logic and either check for error conditions in the request or load data in a predictable way, if they're used at all. I'm not sure what kinds of bugs might be caused by an incorrect param. why does it default to the first phase by start_date? which route(s) does that apply to? it gets pretty confusing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this line needed? I was under the impression that Rails handles requiring all the code under
app/
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still works without it 👍