Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[179] View Evaluator's Submissions #258

Merged
merged 61 commits into from
Dec 9, 2024
Merged

Conversation

emmabjj
Copy link
Contributor

@emmabjj emmabjj commented Nov 7, 2024

Related tickets: #179, #76, #74

Add UI to view evaluators' submissions from the manage evaluator index page.

  • View Evaluator's Submissions #179
  • Allows a challenge manager to view the assigned and unassigned submissions of an evaluator for a particular phase. The different statuses for an evaluator's assigned submissions are either "recused", "in progress", "not started", or "completed".
  • A challenge manager will be able to see the total assigned challenge submissions, the evaluation's due date (the phase's end date), and the number of evaluations completed, in progress, and not started
  • For each assigned submission, a challenge manager will see the submission ID, the evaluation status, the evaluator's score (WIP), and an option to unassign or view an evaluation.
  • For each unassigned submission, a challenge manager will see the submission ID, the evaluation status (unassigned WIP), the evaluator's score (WIP), and an option to reassign the submission to the evaluator.

Add UI and functionality for the Unassign Evaluator from a Submission modal and add functionality to reassign a submission to an evaluator.

I've added controller tests - other tests WIP. The UI is responsive.

evaluator_submissions_view

Screenshot 2024-11-07 at 11 53 21 AM Screenshot 2024-11-07 at 11 53 53 AM

Mobile

Screenshot 2024-11-07 at 11 54 45 AM Screenshot 2024-11-07 at 11 54 56 AM Screenshot 2024-11-07 at 11 55 08 AM Screenshot 2024-11-07 at 11 55 19 AM

@emmabjj emmabjj self-assigned this Nov 7, 2024
@emmabjj emmabjj requested a review from stepchud November 7, 2024 20:32
config/routes.rb Outdated Show resolved Hide resolved
Base automatically changed from 200_manage_evaluators_list to dev November 20, 2024 00:27
@emmabjj emmabjj changed the title WIP - [179] View Evaluator's Submissions [179] View Evaluator's Submissions Nov 22, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a request spec for the #index route here and also spec/system/evaluator_submission_assignment_spec.rb with a11y expect(page).to be_axe_clean and some page interactions assigning and unassigning evaluators with confirmation modal.

Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback on the ordering method

app/models/evaluator_submission_assignment.rb Outdated Show resolved Hide resolved
app/models/evaluator_submission_assignment.rb Outdated Show resolved Hide resolved
.codeclimate.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@emmabjj emmabjj merged commit d7ed2a6 into dev Dec 9, 2024
11 checks passed
@emmabjj emmabjj deleted the 179_evaluator_submissions_view branch December 9, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View Evaluator's Submissions Unassign Evaluators from a Submission
3 participants