-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[237] Evaluation Form validates uniqueness of Phase #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-form-phase-uniqueness * 'dev' of github.com:GSA/Challenge_platform: [183] Rubocop: enable documentation cop (#282)
3 tasks
stepchud
force-pushed
the
237/eval-form-phase-uniqueness
branch
from
December 10, 2024 20:28
e5a89c4
to
327e491
Compare
stepchud
requested changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it's working correctly once I got the migration working, but we'll need to make that change
</select> | ||
<%= select_tag( | ||
'challenge-combo', | ||
options_for_select(options_for_available_phases(@available_phases)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, much cleaner! 🎉
db/migrate/20241125060011_add_unique_phase_constraint_to_evaluation_forms.rb
Show resolved
Hide resolved
…enge_platform into 237/eval-form-phase-uniqueness * '237/eval-form-phase-uniqueness' of github.com:GSA/Challenge_platform: (56 commits) 237 Add unique phase constraint on eval forms Bump rubocop from 1.68.0 to 1.69.1 Bump selenium-webdriver from 4.26.0 to 4.27.0 [304] Collapsible Column Layout (#310) [275-FIX] Fix for max input values for scale types (#288) Update app/views/evaluator_submission_assignments/_unassigned_submission_row.html.erb Update .codeclimate.yml rubocop name Disable rubocop check on flash before render quick syntax fix 179 | Adjust sorting scope and evaluation status quick syntax fix update status colors 179 | Adjust sorting scope and evaluation status Rename stat summary for evaluation submission assignments 179 | Add tests, update statuses, and colors 179 | Update flash, closing date, and error status 179 | Update tests for display scores 179 | Remove unused argument in display_score 179 | Update tests wip 179 | Update ordered by status query ...
stepchud
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#237