Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[237] Evaluation Form validates uniqueness of Phase #294

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

cpreisinger
Copy link
Contributor

…-form-phase-uniqueness

* 'dev' of github.com:GSA/Challenge_platform:
  [183] Rubocop: enable documentation cop (#282)
@cpreisinger cpreisinger requested a review from stepchud November 26, 2024 15:56
@cpreisinger cpreisinger self-assigned this Nov 26, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/03/24 milestone Nov 26, 2024
@r-bartlett-gsa r-bartlett-gsa linked an issue Nov 26, 2024 that may be closed by this pull request
3 tasks
@stepchud stepchud force-pushed the 237/eval-form-phase-uniqueness branch from e5a89c4 to 327e491 Compare December 10, 2024 20:28
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's working correctly once I got the migration working, but we'll need to make that change

</select>
<%= select_tag(
'challenge-combo',
options_for_select(options_for_available_phases(@available_phases)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, much cleaner! 🎉

app/views/evaluation_forms/edit.html.erb Outdated Show resolved Hide resolved
app/views/evaluation_forms/new.html.erb Outdated Show resolved Hide resolved
spec/factories/evaluation_form.rb Show resolved Hide resolved
cpreisinger and others added 5 commits December 10, 2024 23:46
…enge_platform into 237/eval-form-phase-uniqueness

* '237/eval-form-phase-uniqueness' of github.com:GSA/Challenge_platform: (56 commits)
  237 Add unique phase constraint on eval forms
  Bump rubocop from 1.68.0 to 1.69.1
  Bump selenium-webdriver from 4.26.0 to 4.27.0
  [304] Collapsible Column Layout (#310)
  [275-FIX] Fix for max input values for scale types (#288)
  Update app/views/evaluator_submission_assignments/_unassigned_submission_row.html.erb
  Update .codeclimate.yml rubocop name
  Disable rubocop check on flash before render
  quick syntax fix
  179 | Adjust sorting scope and evaluation status
  quick syntax fix
  update status colors
  179 | Adjust sorting scope and evaluation status
  Rename stat summary for evaluation submission assignments
  179 | Add tests, update statuses, and colors
  179 | Update flash, closing date, and error status
  179 | Update tests for display scores
  179 | Remove unused argument in display_score
  179 | Update tests wip
  179 | Update ordered by status query
  ...
@stepchud stepchud merged commit 4646ab0 into dev Dec 11, 2024
11 checks passed
@stepchud stepchud deleted the 237/eval-form-phase-uniqueness branch December 11, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation Form validates uniqueness of Phase
3 participants