[283] Eval Form: Cancelation modal #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-form-cancelation-modal * 'dev' of github.com:GSA/Challenge_platform: (52 commits) [275-FIX] Fix for max input values for scale types (#288) Update app/views/evaluator_submission_assignments/_unassigned_submission_row.html.erb Update .codeclimate.yml rubocop name Disable rubocop check on flash before render quick syntax fix 179 | Adjust sorting scope and evaluation status quick syntax fix update status colors 179 | Adjust sorting scope and evaluation status Rename stat summary for evaluation submission assignments 179 | Add tests, update statuses, and colors 179 | Update flash, closing date, and error status 179 | Update tests for display scores 179 | Remove unused argument in display_score 179 | Update tests wip 179 | Update ordered by status query 179 | Update the display score to check for assignment completion 179 | Update js to use assignment 179 | Update route for evaluation submission assignments 77 | Update recused conditional ...
6 tasks
stepchud
requested changes
Dec 10, 2024
stepchud
reviewed
Dec 10, 2024
…-form-cancelation-modal * 'dev' of github.com:GSA/Challenge_platform: Bump rubocop from 1.68.0 to 1.69.1 Bump selenium-webdriver from 4.26.0 to 4.27.0 [304] Collapsible Column Layout (#310)
…lenge_platform into 283/eval-form-cancelation-modal * '283/eval-form-cancelation-modal' of github.com:GSA/Challenge_platform:
|
Codeclimate failure for "similar" code blocks in the javascript. Should we suppress this warning? |
stepchud
reviewed
Dec 11, 2024
Comment on lines
+7
to
+10
| data-modal-confirm-redirect="<%= defined?(confirm_redirect) ? confirm_redirect : '' %>" | ||
| data-modal-cancel-redirect="<%= defined?(cancel_redirect) ? cancel_redirect : '' %>" | ||
| data-modal-confirm-action="<%= defined?(confirm_action) ? confirm_action : '' %>" | ||
| data-modal-cancel-action="<%= defined?(cancel_action) ? cancel_action : '' %>" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#283
Adds a new modal for confirming redirects/actions