Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[298] Evaluations routes & controller #336

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

[298] Evaluations routes & controller #336

wants to merge 2 commits into from

Conversation

cpreisinger
Copy link
Contributor

@cpreisinger cpreisinger commented Dec 23, 2024 •
edited
Loading

#298

TODO

  • Fix issue with updating scores failing uniqueness constraint (See spec failures)
  • Other spec failure message with inefficient query?
  • Should this prevent creation if their status is recused?
  • Maybe move some logic into model from controller to simplify it
  • Should auth error message just say not found also?

Out of Scope

  • Total score should get set when evaluation is marked as complete

@cpreisinger cpreisinger self-assigned this Dec 23, 2024
@cpreisinger
Merge branch 'dev' of github.com:GSA/Challenge_platform into 298/eval…
90000d7 
…uation-routes-and-controller

* 'dev' of github.com:GSA/Challenge_platform:
  fixes #331 "mass assignment" vuln, permit explicit option labels (#332)
  Bump nanoid from 3.3.7 to 3.3.8 (#330)
  Bump rubocop-rspec from 3.2.0 to 3.3.0 (#324)
  Bump faraday from 2.12.1 to 2.12.2 (#323)
  [Snyk] Security upgrade rails from 7.2.2 to 7.2.2.1 (#320)
  Bump puma from 6.4.3 to 6.5.0 (#289)
  Bump simplecov from 0.17.1 to 0.22.0 (#122)
  [305] Submission Details - Judging Status and Comments (#318)
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/31/24 milestone Dec 26, 2024
@r-bartlett-gsa r-bartlett-gsa linked an issue Dec 26, 2024 that may be closed by this pull request
Evaluations routes & controller #298
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpreisinger cpreisinger

Labels
WIP
Projects
None yet
Milestone
Sprint 01/14/25
Development

Successfully merging this pull request may close these issues.

Evaluations routes & controller
2 participants
@cpreisinger @r-bartlett-gsa