Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[74] Enter Evaluators A11y Fix #343

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Conversation

emmabjj
Copy link
Contributor

@emmabjj emmabjj commented Jan 3, 2025

Related ticket: #200 #74
Figma

Changes made in this PR:

  • Given an existing user who was created without a first and last name,
    when adding that user as an evaluator to a challenge phase,
    then require and update the user with the provided first and last name.
  • Update the UI to use a single field for the first & last name instead of two separate form fields.
  • Update the UI to remove the subtitle below the form fields.
  • Add inline error messages and use usa-alert for form validation.
  • Update the challenge phase title.
  • Make alt text for "Add Evaluator" decorative

Updated UI

Screenshot 2025-01-03 at 1 01 29 PM

Validation errors

Empty form

Screenshot 2025-01-03 at 1 10 52 PM

Only a first name

Screenshot 2025-01-03 at 11 08 35 AM

Missing last name

Screenshot 2025-01-03 at 11 08 46 AM

User with invalid role

Screenshot 2025-01-03 at 11 07 05 AM

Required first and last name for existing user

Screenshot 2025-01-03 at 11 43 49 AM

Existing user without first and last name updated with name entered

Screenshot 2025-01-03 at 11 46 45 AM

Mobile

Screenshot 2025-01-03 at 1 11 18 PM

WAVE

Screenshot 2025-01-03 at 1 13 13 PM

@emmabjj emmabjj self-assigned this Jan 3, 2025
@emmabjj emmabjj requested a review from stepchud January 3, 2025 19:14
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 01/14/25 milestone Jan 3, 2025
@r-bartlett-gsa r-bartlett-gsa linked an issue Jan 3, 2025 that may be closed by this pull request
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enter Evaluators
2 participants