Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset page column to global download and outbound tables #377

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

rshewitt
Copy link
Contributor

@rshewitt rshewitt commented Dec 11, 2024

Changes proposed in this pull request:

  • styling fixes
  • add dataset page column to global download and outbound tables
  • fix correct page title column index for outbound table. download and outbound have different number of columns.

security considerations

[Note the any security considerations here, or make note of why there are none]

Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you have some CSS changes as well?

btylerburton
btylerburton previously approved these changes Dec 11, 2024
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problematic CSS was only applied to the full-width tables so we're good.

Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Nice changes!

styles/partials/overrides.scss Show resolved Hide resolved
@rshewitt rshewitt merged commit 969daa0 into main Dec 11, 2024
6 checks passed
@rshewitt rshewitt deleted the add-dataset-title branch December 11, 2024 21:42
@rshewitt rshewitt restored the add-dataset-title branch December 18, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants