-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digital-239: Custom 12 hour logout #81
base: develop
Are you sure you want to change the base?
Conversation
…-using the same names.
e6beccf
to
3d0c4c0
Compare
@clmedders this is looking good. There is some slight functionality things I noticed that seemed intermittent. Like the popup will sometimes open a bunch of times and not go away. And the new custom module doesn't redirect to logout, it just logs you out. It also does not work if they are both using the modal popup. I found a few more things in the JS where the function names were off or IDs overlapped that might stop it, but apparently it's not perfect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking pretty good, we just need to fix the coding standards errors we inherited https://github.com/GSA/digital-gov-drupal/actions/runs/12469381577
Jira ticket
DIGITAL-239
Purpose
This PR will create a custom module to add the 12 hour log out timer for logging users out
Includes the following PRs that must be merged first
n/a
Deployment and testing
Local Setup
lando rebuild -y && lando si
QA/Testing instructions
Visit
/admin/config/people/dg_autologout
and verify that the time is set to 12 hours and will log a user out no matter role or useChecklist for the Developer
Checklist for the Peer Reviewers