Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital-239: Custom 12 hour logout #81

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

clmedders
Copy link
Contributor

Jira ticket

DIGITAL-239

Purpose

This PR will create a custom module to add the 12 hour log out timer for logging users out

Includes the following PRs that must be merged first

n/a

Deployment and testing

Local Setup

lando rebuild -y && lando si

QA/Testing instructions

Visit /admin/config/people/dg_autologout and verify that the time is set to 12 hours and will log a user out no matter role or use

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mattsqd mattsqd force-pushed the feature/DIGITAL-239-dg-logout branch from e6beccf to 3d0c4c0 Compare December 23, 2024 15:46
@mattsqd
Copy link
Collaborator

mattsqd commented Dec 23, 2024

@clmedders this is looking good. There is some slight functionality things I noticed that seemed intermittent. Like the popup will sometimes open a bunch of times and not go away. And the new custom module doesn't redirect to logout, it just logs you out. It also does not work if they are both using the modal popup. I found a few more things in the JS where the function names were off or IDs overlapped that might stop it, but apparently it's not perfect.
If we can just 'fix' the new coding standards errors that we inherited from their project, we should be good. https://github.com/GSA/digital-gov-drupal/actions/runs/12469381577

Copy link
Collaborator

@mattsqd mattsqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking pretty good, we just need to fix the coding standards errors we inherited https://github.com/GSA/digital-gov-drupal/actions/runs/12469381577

@clmedders clmedders marked this pull request as ready for review December 23, 2024 19:38
@clmedders clmedders requested a review from mattsqd December 23, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants