-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIGITAL-47 guide nav templates #82
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerida
force-pushed
the
feature/DIGITAL-47-guide-nav-templates
branch
2 times, most recently
from
December 18, 2024 22:00
551a8b4
to
7bdf0a8
Compare
omerida
changed the title
Feature/digital 47 guide nav templates
DIGITAL-47 guide nav templates
Dec 20, 2024
Adds content type for guide navigation collection. Adds optional title field for guide nodes to use in navigation collection. Adds paragraph fields for guide nav links and sub-navigation.
* Render the desktop navigation for guides. * Render the mobile navigation for guides. * Show summary and title below nav * Show prev/next links if enabled. * Show summary box if enabled * Show reading time if enabled * Display overview page elements in header. * Link to parent guide in header if set. * Show sidebar navigation if enabled.
omerida
force-pushed
the
feature/DIGITAL-47-guide-nav-templates
branch
from
December 20, 2024 20:46
7bdf0a8
to
e74572e
Compare
…-guide-nav-templates
… they'll be removed on view.
…orted, rerolled patch for overwriting files, added new patch to allow ignore exporting specific content. Switched default_content to dev branch so circular reference patch could be applied.
…SA/digital-gov-drupal into feature/DIGITAL-47-guide-nav-templates
mattsqd
previously approved these changes
Dec 30, 2024
…-guide-nav-templates # Conflicts: # config/sync/core.entity_form_display.node.guides.default.yml # config/sync/core.entity_view_display.node.guides.default.yml # config/sync/core.entity_view_display.node.guides.teaser.yml # web/themes/custom/digital_gov/templates/node/node--guides.html.twig
# Conflicts: # config/sync/core.entity_form_display.node.guides.default.yml # config/sync/core.entity_view_display.node.guides.default.yml # config/sync/core.entity_view_display.node.guides.teaser.yml # web/themes/custom/digital_gov/templates/node/node--guides.html.twig
* Fix WSOD when no parent guide is set.
@mattsqd I fixed merge conflicts. |
# Conflicts: # web/modules/custom/default_content_config/content/node/91b1798f-4dec-49d6-bfee-38ed0a4f5e49.yml # web/modules/custom/default_content_config/content/node/c4520a54-cd38-4be0-9158-24a61a79599e.yml
…aragraph references to work.
…e guide navigation nodes.
…sure that it works.
…in to edit guide navigation nodes.
…SA/digital-gov-drupal into feature/DIGITAL-47-guide-nav-templates # Conflicts: # config/sync/core.entity_form_display.node.guides.default.yml # config/sync/core.entity_view_display.node.guides.default.yml # config/sync/core.entity_view_display.node.guides.teaser.yml
mattsqd
approved these changes
Jan 1, 2025
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
DIGITAL-42
and
DIGITAL-47
Purpose
Adds content type for guide navigation collection. Adds optional title field for guide nodes to use in navigation collection. Adds paragraph fields for guide nav links and subnav.
New content type: guide nav. It can hold one or more links. Links can optionally have a subnav. Has Checkbox bool fields to match config fields in hugo frontmatter. Adds a reference field so a guide can point to a parent guide to link to above the guide title.
Adds a group of guide nav related fields to the guide content type.
Adds a "guide nav admin" role that can add/edit/delete guidenav nodes.
Adds template and preprocess function to help build:
Includes the following PRs that must be merged first
Deployment and testing
Local Setup
lando si
will re-create the site with a "Test guide nav" node that links to existing guide pages. There's some bug/race condition that doesn't set all the references however. You'll need to manually:QA/Testing instructions
Checklist for the Developer
Checklist for the Peer Reviewers