Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital-233: Creating the homepage content #86

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

clmedders
Copy link
Contributor

Jira ticket

DIGITAL-233

Purpose

This PR will set up/add a landing page type for home page and migrate over templets along with placeholder for future work

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

lando rebuild -y

QA/Testing instructions

  1. go to content and check the page title Better websites. Better government. and verify that it has homepage for landing page type and placeholder are present
  2. review twig file and check for overall code quality

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review December 20, 2024 18:54
@clmedders clmedders requested a review from mattsqd December 20, 2024 18:54
@clmedders clmedders requested a review from mattsqd January 2, 2025 18:44
mattsqd
mattsqd previously approved these changes Jan 6, 2025
@mattsqd mattsqd merged commit 986e9a9 into develop Jan 6, 2025
2 checks passed
@mattsqd mattsqd deleted the feature/DIGITAL-233-homepage-content branch January 6, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants