Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIGITAL-143: Update topics to autocomplete field #88

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

DIGITAL-143: Update topics to autocomplete field #88

wants to merge 1 commit into from

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Dec 23, 2024 •
edited
Loading

Jira ticket

DIGITAL-143

Purpose

This PR will update the topics field from inline form to autocomplete

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

lando rebuild -y

QA/Testing instructions

  1. Visit events, guides, news, resources, short post and check that topics is now autocomplete.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review December 23, 2024 17:59
@clmedders clmedders requested a review from mattsqd December 23, 2024 17:59
mattsqd
mattsqd requested changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@mattsqd mattsqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ask here was to use the https://www.drupal.org/project/autocomplete_deluxe module. It's way sweeter than the built in entity reference field. Check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsqd mattsqd mattsqd requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @mattsqd