Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIGITAL-48: glossary templates #93

Merged
merged 10 commits into from
Jan 6, 2025
Merged

DIGITAL-48: glossary templates #93

merged 10 commits into from
Jan 6, 2025

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Jan 2, 2025

Jira ticket

DIGITAL-48

Purpose

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

lando si to get the content and config to see the glossary on a page.

QA/Testing instructions

  1. Visit https://digitalgov.lndo.site/guides/web-analytics-playbook
  2. Click on Glossary link in guide header
  3. Glossary sidebar displays on right side of screen
  4. Clicking a term to show/hide it
  5. Searching for a term displays matches

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

omerida added 3 commits January 2, 2025 11:39
@omerida
DIGITAL-48: Show Guide Glossary
88da8ec 
* Shows the guide glossary terms in a sidebar.
@omerida
DIGITAL-48: Migrate Glossary Templates
04c9068 
* Creates view to display glossary terms.
* Render glossary terms view on guide node templates.
* Update glossary JavaScript to work with pre-rendered terms in the DOM
@omerida
DIGITAL-48: Clean up twig linting
3b6ad21
@omerida omerida requested a review from mattsqd January 2, 2025 16:48
mattsqd added 7 commits January 6, 2025 10:49
@mattsqd
Merge remote-tracking branch 'origin/develop' into feature/DIGITAL-48…
0d1ea6c 
…-glossary-templates
@mattsqd
DIGITAL-48: Put a warning in here that we modified this file the next…
da473af 
… time we copy in the JS and CSS from the current site.
@mattsqd
DIGITAL-48: Remove validation for 'view' on vocabulary. Anonymous use…
bca163c 
…rs cannot view vocabs and the terms publish status will be respected.
@mattsqd
DIGITAL-48: Added a local package.json so that we could run an http s…
c627861 
…erver for the tome export command.
@mattsqd
DIGITAL-48: Added a robo static function to allow exporting the site …
8eabcc2 
…to static content.
@mattsqd
DIGITAL-48: Added an alias for drupal-project:export-content to just …
d03f18b 
…export-content.
@mattsqd
DIGITAL-48: Added documentation about the new static command.
707f838
@mattsqd mattsqd merged commit cbdea7a into develop Jan 6, 2025
2 checks passed
@mattsqd mattsqd deleted the feature/DIGITAL-48-glossary-templates branch January 6, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsqd mattsqd mattsqd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerida @mattsqd