Skip to content

Commit

Permalink
Add 'inventory-item-has-software-name' constraint and tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Gabeblis committed Dec 27, 2024
1 parent b79ec53 commit 9e60aaa
Show file tree
Hide file tree
Showing 5 changed files with 46 additions and 0 deletions.
3 changes: 3 additions & 0 deletions features/fedramp_extensions.feature
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ Examples:
| interconnection-direction |
| interconnection-security |
| inventory-item-allows-authenticated-scan |
| inventory-item-has-software-name |
| inventory-item-public |
| inventory-item-virtual |
| leveraged-authorization-has-authorization-type |
Expand Down Expand Up @@ -354,6 +355,8 @@ Examples:
| interconnection-security-PASS.yaml |
| inventory-item-allows-authenticated-scan-FAIL.yaml |
| inventory-item-allows-authenticated-scan-PASS.yaml |
| inventory-item-has-software-name-FAIL.yaml |
| inventory-item-has-software-name-PASS.yaml |
| inventory-item-public-FAIL.yaml |
| inventory-item-public-PASS.yaml |
| inventory-item-virtual-FAIL.yaml |
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<system-security-plan xmlns="http://csrc.nist.gov/ns/oscal/1.0" uuid="11111111-2222-4000-8000-000000000000">
<system-implementation>
<component uuid="11111111-2222-4000-8000-009000000007" type="software">
<!-- <prop name="software-name" value="software-name"/> Missing software-name in linked component-->
</component>
<inventory-item uuid="11111111-2222-4000-8000-011000000001">
<prop name="asset-type" value="operating-system"/>
<!-- <prop name="software-name" value="software-name"/> Missing software-name in inventory-item.-->
<implemented-component component-uuid="11111111-2222-4000-8000-009000000007">
</implemented-component>
</inventory-item>
</system-implementation>
</system-security-plan>
12 changes: 12 additions & 0 deletions src/validations/constraints/fedramp-external-constraints.xml
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,18 @@
</constraints>
</context>

<context>
<metapath target="/system-security-plan/system-implementation/inventory-item"/>
<constraints>
<let var ="component-uuid" expression="implemented-component/@component-uuid"/>
<expect id="inventory-item-has-software-name" target=".[prop[@name='asset-type' and @value=('operating-system', 'container', 'image')] or ../component[uuid=$component-uuid and type='software']]" test="count(prop[@name=('software-name', 'os-name')]) >= 1 or count(../component[@uuid=$component-uuid]/prop[@name=('software-name', 'os-name')]) >= 1" level="ERROR">
<formal-name>Inventory Item Has Software Name</formal-name>
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
<message>In a FedRAMP SSP, each inventory item MUST include the software name in the inventory item itself or within the linked component.</message>
</expect>
</constraints>
</context>

<context>
<metapath target="/(assessment-plan|assessment-results|plan-of-action-and-milestones|system-security-plan)/metadata"/>
<constraints>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Negative Test for inventory-item-has-software-name
description: >-
This test case validates the behavior of constraint
inventory-item-has-software-name
content: ../content/ssp-inventory-item-has-software-name-INVALID.xml
expectations:
- constraint-id: inventory-item-has-software-name
result: fail
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Positive Test for inventory-item-has-software-name
description: >-
This test case validates the behavior of constraint
inventory-item-has-software-name
content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
expectations:
- constraint-id: inventory-item-has-software-name
result: pass

0 comments on commit 9e60aaa

Please sign in to comment.