Add 'inventory-item-has-asset-type' constraint and tests (#1078)

features/fedramp_extensions.feature

@@ -125,6 +125,7 @@ Examples:
   | interconnection-security |
   | inventory-item-allows-authenticated-scan |
   | inventory-item-and-component-has-public |
+  | inventory-item-has-asset-type |
   | inventory-item-has-diagram-label |
   | inventory-item-has-function |
   | inventory-item-has-is-scanned |
@@ -394,6 +395,8 @@ Examples:
   | inventory-item-allows-authenticated-scan-PASS.yaml |
   | inventory-item-and-component-has-public-FAIL.yaml |
   | inventory-item-and-component-has-public-PASS.yaml |
+  | inventory-item-has-asset-type-FAIL.yaml |
+  | inventory-item-has-asset-type-PASS.yaml |
   | inventory-item-has-diagram-label-FAIL.yaml |
   | inventory-item-has-diagram-label-PASS.yaml |
   | inventory-item-has-function-FAIL.yaml |

src/validations/constraints/content/ssp-inventory-item-has-asset-type-INVALID.xml

@@ -0,0 +1,7 @@
+<system-security-plan xmlns="http://csrc.nist.gov/ns/oscal/1.0" uuid="11111111-2222-4000-8000-000000000000">
+  <system-implementation>
+    <inventory-item uuid="11111111-2222-4000-8000-011000000001">
+      <!-- <prop name="asset-type" value="operating-system"/> Missing "asset-type" prop. -->
+    </inventory-item>
+  </system-implementation>
+</system-security-plan>

src/validations/constraints/fedramp-external-constraints.xml

@@ -694,6 +694,11 @@
                 <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
                 <message>For HIGH-impact systems, every inventory-item MUST identify an asset-owner or administrator property either within the inventory-item itself, or within the component linked by the inventory-item.</message>
             </expect>
+            <expect id="inventory-item-has-asset-type" target="." test="count(prop[@name='asset-type' ]) = 1 or count(../component[@uuid=$component-uuid]/prop[@name='asset-type' ]) = 1" level="ERROR">
+                <formal-name>Inventory Item Has Asset-Type</formal-name>
+                <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
+                <message>In a FedRAMP SSP, each inventory item MUST define the asset type either in the inventory item itself or within the linked component.</message>
+            </expect>
             <expect id="inventory-item-has-diagram-label" target="." test="count(prop[@name='diagram-label' and @ns='http://fedramp.gov/ns/oscal']) >= 1 or count(../component[@uuid=$component-uuid]/prop[@name='diagram-label' and @ns='http://fedramp.gov/ns/oscal']) >= 1" level="ERROR">
                 <formal-name>Inventory Item Has Diagram Label</formal-name>
                 <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>

src/validations/constraints/unit-tests/inventory-item-has-asset-type-FAIL.yaml

@@ -0,0 +1,9 @@
+test-case:
+  name: Negative Test for inventory-item-has-asset-type
+  description: >-
+    This test case validates the behavior of constraint
+    inventory-item-has-asset-type
+  content: ../content/ssp-inventory-item-has-asset-type-INVALID.xml
+  expectations:
+    - constraint-id: inventory-item-has-asset-type
+      result: fail

src/validations/constraints/unit-tests/inventory-item-has-asset-type-PASS.yaml

@@ -0,0 +1,9 @@
+test-case:
+  name: Positive Test for inventory-item-has-asset-type
+  description: >-
+    This test case validates the behavior of constraint
+    inventory-item-has-asset-type
+  content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
+  expectations:
+    - constraint-id: inventory-item-has-asset-type
+      result: pass