Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory - Asset Type #1040

Open
11 of 15 tasks
Rene2mt opened this issue Dec 26, 2024 · 0 comments · Fixed by #1078
Open
11 of 15 tasks

Inventory - Asset Type #1040

Rene2mt opened this issue Dec 26, 2024 · 0 comments · Fixed by #1078

Comments

@Rene2mt
Copy link
Member

Rene2mt commented Dec 26, 2024

Constraint Task

Consistent with issue #813, this constraint focuses on validating information that describes the asset's function (e.g., router, storage array, DNS server, etc.).

NOTE - Mandatory for OS/Infrastructure, Containers. Leave blank for Software and Database.

Intended Outcome

  • Every inventory-item MUST have an "asset-type" property either within the inventory-item itself, or within the component linked by the inventory-item

Syntax Type

This is optional core OSCAL syntax.

Allowed Values

FedRAMP allowed values must be defined or verified.

Metapath(s) to Content

context="//inventory-item"

target=". | //component[@uuid=./implemented-component/@component-uuid]"

count(./prop[@name='asset-type' ]) >= 1

Purpose of the OSCAL Content

No response

Dependencies

No response

Acceptance Criteria

  • All OSCAL adoption content affected by the change in this issue have been updated in accordance with the Documentation Standards.
    • Explanation is present and accurate
    • sample content is present and accurate
    • Metapath is present, accurate, and does not throw a syntax exception using oscal-cli metaschema metapath eval -e "expression".
  • All constraints associated with the review task have been created
  • The appropriate example OSCAL file is updated with content that demonstrates the FedRAMP-compliant OSCAL presentation.
  • The constraint conforms to the FedRAMP Constraint Style Guide.
    • All automated and manual review items that identify non-conformance are addressed; or technical leads (David Waltermire; AJ Stein) have approved the PR and “override” the style guide requirement.
  • Known good test content is created for unit testing.
  • Known bad test content is created for unit testing.
  • Unit testing is configured to run both known good and known bad test content examples.
  • Passing and failing unit tests, and corresponding test vectors in the form of known valid and invalid OSCAL test files, are created or updated for each constraint.
  • A Pull Request (PR) is submitted that fully addresses the goals section of the User Story in the issue.
  • This issue is referenced in the PR.

Other information

In addition to the core NIST OSCAL allowed values for "asset-type", FedRAMP adds "image" and "container" as allowed values. We may need an allowed values constraint with @allow-other="yes"

@aj-stein-gsa aj-stein-gsa moved this from 🆕 New to 🔖 Ready in FedRAMP Automation Jan 3, 2025
@aj-stein-gsa aj-stein-gsa moved this from 🔖 Ready to 📋 Backlog in FedRAMP Automation Jan 3, 2025
@Rene2mt Rene2mt moved this from 📋 Backlog to 🔖 Ready in FedRAMP Automation Jan 8, 2025
@Gabeblis Gabeblis self-assigned this Jan 8, 2025
@Gabeblis Gabeblis moved this from 🔖 Ready to 🏗 In progress in FedRAMP Automation Jan 8, 2025
@Gabeblis Gabeblis linked a pull request Jan 8, 2025 that will close this issue
7 tasks
@Gabeblis Gabeblis moved this from 🏗 In progress to 👀 In review in FedRAMP Automation Jan 8, 2025
@aj-stein-gsa aj-stein-gsa moved this from 👀 In review to 🚢 Ready to Ship in FedRAMP Automation Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚢 Ready to Ship
Development

Successfully merging a pull request may close this issue.

2 participants