-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inventory-item-has-asset-type
Constraint
#1078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
wandmagic
previously approved these changes
Jan 10, 2025
Rene2mt
previously approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!! Will need a rebase before merging though.
Gabeblis
force-pushed
the
constraints/issue-1040
branch
from
January 13, 2025 14:11
3894a73
to
8357cbd
Compare
Rene2mt
previously approved these changes
Jan 14, 2025
wandmagic
previously approved these changes
Jan 14, 2025
wandmagic
previously approved these changes
Jan 14, 2025
@Rene2mt merged in latest changes from develop, needs another review |
wandmagic
force-pushed
the
constraints/issue-1040
branch
from
January 14, 2025 13:32
4de0faf
to
6cc7c67
Compare
wandmagic
previously approved these changes
Jan 14, 2025
Gabeblis
force-pushed
the
constraints/issue-1040
branch
from
January 14, 2025 15:05
6cc7c67
to
fb26487
Compare
wandmagic
approved these changes
Jan 14, 2025
Rene2mt
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Purpose
This PR aims to add the
inventory-item-has-asset-type
constraint which ensures that each inventory item, or it's linked component, has the "asset-type" prop.Changes
Added constraint:
inventory-item-has-asset-type
Added invalid test content:
ssp-inventory-item-has-is-scanned-INVALID.xml
Added yaml files for testing:
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.