Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory-item-has-is-scanned Constraint #1077

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Jan 8, 2025

Committer Notes

Purpose

This PR aims to add the inventory-item-has-is-scanned constraint which ensures that each inventory item, or it's linked component, has the "is-scanned" prop that states if it is included in scans or not.

Changes

Added constraint:

  • inventory-item-has-is-scanned

Added valid/invalid test content:

  • ssp-inventory-item-has-is-scanned-INVALID.xml
  • Edited fedramp-ssp-example.oscal.xml to align with constraint

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Jan 8, 2025
@Gabeblis Gabeblis requested a review from a team as a code owner January 8, 2025 15:24
@Gabeblis Gabeblis linked an issue Jan 8, 2025 that may be closed by this pull request
15 tasks
wandmagic
wandmagic previously approved these changes Jan 10, 2025
Rene2mt
Rene2mt previously approved these changes Jan 10, 2025
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Rene2mt Rene2mt dismissed stale reviews from wandmagic and themself via de3fd39 January 10, 2025 17:49
@Rene2mt
Copy link
Member

Rene2mt commented Jan 10, 2025

@Gabeblis would you mind updating this PR? I resolved the merge conflict after approving it but may have put the constraint in the wrong locations so now its failing some of the style guide tests.

@Gabeblis Gabeblis force-pushed the constraints/issue-1042 branch from de3fd39 to bcacba4 Compare January 10, 2025 18:54
@Gabeblis Gabeblis requested review from Rene2mt and wandmagic January 10, 2025 18:55
@Gabeblis
Copy link
Contributor Author

@Gabeblis would you mind updating this PR? I resolved the merge conflict after approving it but may have put the constraint in the wrong locations so now its failing some of the style guide tests.

I fixed the rebase 🫡

@wandmagic wandmagic merged commit e309bd0 into GSA:develop Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory - Is Scanned
3 participants