Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

has sensitivity-level constraint #742

Closed

Conversation

wandmagic
Copy link
Collaborator

Committer Notes

Introducing a small constraint to assure the SSP has a sensitivity level

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic wandmagic requested a review from a team as a code owner October 1, 2024 10:53
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are looking good, but I thought we decided to slim down the negative test fixture data per ADR 6?

@wandmagic
Copy link
Collaborator Author

slimmed

@aj-stein-gsa aj-stein-gsa changed the title has sensitivity-level constraint [DONOTMERGE] has sensitivity-level constraint Oct 1, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I need to wrap documentation for the PR connected to GSA/automate.fedramp.gov#55 and close that for this to be ready. If it is not complete at the end of the day.

@aj-stein-gsa
Copy link
Contributor

We need to rebase this PR but the related documentation branch is settling, we should be good to go soon. Let's wrap up review hopefully today or early tomorrow, @wandmagic.

@aj-stein-gsa aj-stein-gsa changed the title [DONOTMERGE] has sensitivity-level constraint has sensitivity-level constraint Oct 29, 2024
@Gabeblis
Copy link

We need to rebase this PR but the related documentation branch is settling, we should be good to go soon. Let's wrap up review hopefully today or early tomorrow, @wandmagic.

I just noticed this PR. This constraint was already included in #669

@wandmagic wandmagic closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants