Merge pull request #1957 from GSA/notify-admin-1936

Fix serious a11y violations reported by axe-core
GSA · Sep 23, 2024 · a5889d3 · a5889d3
2 parents 09a775f + 8b6f719
commit a5889d3
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/app/assets/stylesheets/main.scss b/app/assets/stylesheets/main.scss
@@ -34,6 +34,11 @@ $path: '/static/images/';
 // Dependencies from GOV.UK Frontend, packaged to be specific to this application
 @import './govuk-frontend/all';
 
+// Custom overrides
+.govuk-link {
+    font-weight: bold;
+}
+
 // Specific to this application
 @import 'local/typography';
 @import 'grids';

diff --git a/app/templates/views/dashboard/dashboard.html b/app/templates/views/dashboard/dashboard.html
@@ -46,7 +46,7 @@ <h2 class="line-height-sans-2 margin-bottom-0 margin-top-4">Recent activity</h2>
       <div id="activityChart">
         <div class="chart-header">
           <div class="chart-subtitle">{{ current_service.name }} - last 7 days</div>
-          <div class="chart-legend" aria-label="Legend"></div>
+          <div class="chart-legend" role="region" aria-label="Legend"></div>
         </div>
         <div class="chart-container" id="weeklyChart"></div>
         <table id="weeklyTable" class="usa-sr-only usa-table"></table>

diff --git a/app/templates/views/templates/template.html b/app/templates/views/templates/template.html
@@ -63,24 +63,29 @@ <h3 class="margin-bottom-0">More actions</h3>
           href="{{ url_for('.view_template_versions', service_id=current_service.id, template_id=template.id) }}">See previous
           versions</a>
         </li>
+      </ul>
         {% endif %}
         {% if current_user.has_permissions('manage_templates') and user_has_template_permission %}
         {% if not template._template.archived %}
+        <ul class="usa-list usa-list--unstyled">
         <li>
           <a class="usa-link margin-right-3"
           href="{{ url_for('.delete_service_template', service_id=current_service.id, template_id=template.id) }}">Delete this
           template</a>
         </li>
+        </ul>
         {% endif %}
         {% if not template._template.redact_personalisation %}
+        <ul class="usa-list usa-list--unstyled">
         <li>
           <a class="usa-link" href="{{ url_for('.confirm_redact_template', service_id=current_service.id, template_id=template.id) }}">Hide all personalized and conditional content after sending</a> for increased privacy protection
         </li>
+        </ul>
         {% else %}
         <p class="hint">Personalization is hidden after sending</p>
       {% endif %}
     {% endif %}
-    </ul>
+
   </div>
 
   <!--<div class="">

diff --git a/tests/end_to_end/conftest.py b/tests/end_to_end/conftest.py
@@ -37,5 +37,4 @@ def check_axe_report(page):
         assert violation["impact"] in [
             "minor",
             "moderate",
-            "serious",
         ], f"Accessibility violation: {violation}"