Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production deploy 1/30/24 #1173

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Production deploy 1/30/24 #1173

merged 6 commits into from
Jan 30, 2024

Conversation

ccostino
Copy link
Contributor

@ccostino ccostino commented Jan 30, 2024 •
edited
Loading

Please see the 01/30/2024 release notes for more details.

Kenneth Kehl and others added 6 commits January 29, 2024 13:17
notify-admin-1137 make sure one-off files get written to db
7c5674c
@ccostino
Update Cloud Foundry Terraform module
0f167a9 
This changeset updates the Cloud Foundry Terraform to its latest release.  Our file were previously referencing a very old version, which was contributing to infrastructure check and deployment failures.

Signed-off-by: Carlo Costino <[email protected]>
@ccostino
Updated 18F/terraform-cloudgov to v0.7.1
4da5c14 
Signed-off-by: Carlo Costino <[email protected]>
@ccostino
Remove the profile attribute entirely
50e3560 
This was what was apparently breaking our Terraform actions.  I traced this to an undocumented breaking change with the AWS provider; more details can be seen here: https://discuss.hashicorp.com/t/error-error-configuring-terraform-aws-provider-failed-to-get-shared-config-profile-default/39417/2

Signed-off-by: Carlo Costino <[email protected]>
@ccostino
Merge pull request #1167 from GSA/notify-admin-1148
f097b9c 
notify-admin-1148 make sure one-off files get written to db
@ccostino
Merge pull request #1170 from GSA/fix-infrastructure-checks
27385bc 
Fix Terraform commands and actions
@ccostino ccostino self-assigned this Jan 30, 2024
@github-actions GitHub Actions
Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan 

module.redis.data.cloudfoundry_service.redis: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.redis.data.cloudfoundry_space.space: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.redis.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=5e7cbb6b-81b7-4f5f-9b55-fd11a62fe5e9]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 1s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e384e68-c487-4645-af82-17b91c46ce05]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 1s [id=e4752004-ae2c-4b0f-bdf5-4a0c359fbfb9]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 1s [id=4d29c834-baf5-4733-8034-41a764cde950]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=f016d719-5e07-2f05-7865-50a3c10be0a1]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.logo_upload_bucket.cloudfoundry_service_instance.bucket,
  on .terraform/modules/logo_upload_bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and one more similar warning elsewhere)

Pusher: @ccostino, Action: pull_request

@github-actions GitHub Actions
Copy link

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan 

module.redis.data.cloudfoundry_service.redis: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_service.external_domain: Reading...
module.domain.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.domain.data.cloudfoundry_app.app: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Read complete after 1s [id=9bd7f50c-8c53-4277-8839-9af17f8bca40]
module.redis.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.redis.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=c3f1065e-aca4-45ba-9749-56391f028d44]
module.domain.data.cloudfoundry_service.external_domain: Read complete after 1s [id=ef75a1d4-3d69-4deb-8704-626a36d02a93]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 2s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e4972b9-c75d-4a84-927f-de4ec17a30d3]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 1s [id=f6215fcd-2784-455d-bb4c-29570c03d284]
module.domain.data.cloudfoundry_app.app: Read complete after 2s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.domain.cloudfoundry_route.origin_route: Refreshing state... [id=a9b8f112-116d-44bb-938e-192db047667e]
module.domain.cloudfoundry_service_instance.external_domain_instance: Refreshing state... [id=ab3354f3-4c3c-4979-852b-357878bd955e]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 2s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=3402a08a-fdec-c6ce-af28-b378e2ec4a32]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on .terraform/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 2 more similar warnings elsewhere)

Pusher: @ccostino, Action: pull_request

@ccostino ccostino changed the title Production deploy 1/3/24 Production deploy 1/30/24 Jan 30, 2024
@ccostino ccostino requested review from stvnrlly and tdlowden January 30, 2024 20:29
@ccostino ccostino merged commit a15feca into production Jan 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdlowden tdlowden tdlowden approved these changes

@stvnrlly stvnrlly Awaiting requested review from stvnrlly

Assignees

@ccostino ccostino

Labels
engineering
Projects
Notify.gov product board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccostino @tdlowden