Removed old redis from terraform.

[xlorepdarkhelm]

A note to PR reviewers: it may be helpful to review our
code review documentation
to know what to keep in mind while reviewing pull requests.

Description

Removing the old, inept version of redis from terraform, as everything is pointing to the new shiny v70.

This is the final part of GSA/notifications-api#978. 🎉

Security Considerations

• We don't want to leave old, unsupported service instances lying around.

[github-actions]

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan

null_resource.prevent_destroy: Refreshing state... [id=1728082765789994772]
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=a6e88a48-bae7-4cf4-84d5-3a86463e8814]
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 0s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=13ac7990-e80e-4c07-8208-f6736a87c1d2]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 0s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 0s [id=9745decb-4988-4bab-88a4-e3f07b36241c]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=d67c8c05-f22b-4fca-ba0b-312af08a61eb]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 1s [id=5d983d08-5079-4159-8721-67edf948d345]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 1s [id=89c9b6a9-f030-4752-b30f-6b3193a25148]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=45c461a7-cc6c-c60d-cea7-1f5480589b64]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # module.redis.cloudfoundry_service_instance.redis will be destroyed
  # (because cloudfoundry_service_instance.redis is not in configuration)
  - resource "cloudfoundry_service_instance" "redis" {
      - id                             = "a6e88a48-bae7-4cf4-84d5-3a86463e8814" -> null
      - labels                         = {} -> null
      - name                           = "notify-admin-redis-staging" -> null
      - recursive_delete               = true -> null
      - replace_on_params_change       = false -> null
      - replace_on_service_plan_change = false -> null
      - service_plan                   = "39e035d8-f847-4bf5-a2ee-521c3118cc42" -> null
      - space                          = "9745decb-4988-4bab-88a4-e3f07b36241c" -> null
      - tags                           = [] -> null
    }

Plan: 0 to add, 0 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.logo_upload_bucket.cloudfoundry_service_instance.bucket,
  on .terraform/modules/logo_upload_bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @xlorepdarkhelm, Action: pull_request

[A-Shumway42]

LGTM!