07/16/2024 Production Deploy #1729

ccostino · 2024-07-16T17:25:23Z

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

This is a production deploy for 7/16/2024. Full release notes are here!

Security Considerations

All changes have been reviewed and tested prior to being included here.

This changeset updates several Python dependencies that Dependabot has flagged. It also ignores a pip-audit report of idna, which incorrectly flagged the version we are on as having been affected by PYSEC-2024-60; this was fixed in version 3.7 of idna, which we are currently using. We will update the action again once the audit flag is corrected and/or another fix version is released (if needed). Signed-off-by: Carlo Costino <[email protected]>

Update Python dependencies - 7/12/24 - and ignore idna pip-audit flag

handle compliance issue #46

fix pending on dashboard

add handling for 90 day email check

This changeset updates several Python dependencies that were being picked up by Dependabot. Signed-off-by: Carlo Costino <[email protected]>

Update Python dependencies - 7/16/24

another tweak for session management

github-actions · 2024-07-17T21:46:26Z

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan


module.redis-v70.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_service.external_domain: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Read complete after 0s [id=9bd7f50c-8c53-4277-8839-9af17f8bca40]
module.domain.data.cloudfoundry_service.external_domain: Read complete after 0s [id=ef75a1d4-3d69-4deb-8704-626a36d02a93]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=17e1e72f-74ef-459d-9bf1-3c5c8f44c00a]
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e4972b9-c75d-4a84-927f-de4ec17a30d3]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.domain.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.domain.data.cloudfoundry_app.app: Reading...
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 0s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.domain.data.cloudfoundry_app.app: Read complete after 0s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.domain.cloudfoundry_route.origin_route: Refreshing state... [id=a9b8f112-116d-44bb-938e-192db047667e]
module.domain.cloudfoundry_service_instance.external_domain_instance: Refreshing state... [id=ab3354f3-4c3c-4979-852b-357878bd955e]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 0s [id=f6215fcd-2784-455d-bb4c-29570c03d284]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=3402a08a-fdec-c6ce-af28-b378e2ec4a32]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on .terraform/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and one more similar warning elsewhere)

Pusher: @ccostino, Action: pull_request

Delete outdated Redis instance from Sandbox Terraform config

github-actions · 2024-07-17T22:03:14Z

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan


module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.domain.data.cloudfoundry_service.external_domain: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.domain.data.cloudfoundry_domain.origin_url: Read complete after 0s [id=9bd7f50c-8c53-4277-8839-9af17f8bca40]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.domain.data.cloudfoundry_service.external_domain: Read complete after 1s [id=ef75a1d4-3d69-4deb-8704-626a36d02a93]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.domain.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.domain.data.cloudfoundry_app.app: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e4972b9-c75d-4a84-927f-de4ec17a30d3]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=17e1e72f-74ef-459d-9bf1-3c5c8f44c00a]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.domain.data.cloudfoundry_app.app: Read complete after 1s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.domain.cloudfoundry_route.origin_route: Refreshing state... [id=a9b8f112-116d-44bb-938e-192db047667e]
module.domain.cloudfoundry_service_instance.external_domain_instance: Refreshing state... [id=ab3354f3-4c3c-4979-852b-357878bd955e]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 1s [id=976ab9e0-8729-4c15-96e0-2643ab938354]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 1s [id=f6215fcd-2784-455d-bb4c-29570c03d284]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=3402a08a-fdec-c6ce-af28-b378e2ec4a32]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on .terraform/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and one more similar warning elsewhere)

Pusher: @ccostino, Action: pull_request

github-actions · 2024-07-17T22:03:15Z

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan


module.logo_upload_bucket.data.cloudfoundry_space.space: Reading...
module.api_network_route.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.logo_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 1s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.logo_upload_bucket.data.cloudfoundry_service.s3: Read complete after 1s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis-v70.cloudfoundry_service_instance.redis: Refreshing state... [id=a1c6e6bb-775d-4bd8-ae03-5a045048a31f]
module.api_network_route.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.api_network_route.data.cloudfoundry_app.destination_app: Reading...
module.api_network_route.data.cloudfoundry_app.source_app: Reading...
module.logo_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.logo_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=9e384e68-c487-4645-af82-17b91c46ce05]
module.api_network_route.data.cloudfoundry_app.destination_app: Read complete after 0s [id=e4752004-ae2c-4b0f-bdf5-4a0c359fbfb9]
module.api_network_route.data.cloudfoundry_app.source_app: Read complete after 0s [id=4d29c834-baf5-4733-8034-41a764cde950]
module.api_network_route.cloudfoundry_network_policy.internal_route: Refreshing state... [id=f016d719-5e07-2f05-7865-50a3c10be0a1]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.logo_upload_bucket.cloudfoundry_service_instance.bucket,
  on .terraform/modules/logo_upload_bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

Pusher: @ccostino, Action: pull_request

Kenneth Kehl and others added 18 commits July 11, 2024 09:38

ugh

058a999

skip e2e

272d321

fix import

18333b9

fix import sorting

df9efb3

Merge pull request #1720 from GSA/update-python-deps-7-12-24

6ee9849

Update Python dependencies - 7/12/24 - and ignore idna pip-audit flag

merge from main

b50e90e

fix pending on dashboard

6be474e

code review feedback

2be7e61

code review feedback

18331d0

Merge pull request #1719 from GSA/notify-compliance-46d

7302c0b

handle compliance issue #46

Merge pull request #1721 from GSA/notify-admin-1573

437f8ca

fix pending on dashboard

add handling for 90 day email check

228c4cd

fix

b778292

Merge pull request #1724 from GSA/notify-compliance-46d

329d9d7

add handling for 90 day email check

Update Python dependencies - 7/16/24

361b936

This changeset updates several Python dependencies that were being picked up by Dependabot. Signed-off-by: Carlo Costino <[email protected]>

Merge pull request #1726 from GSA/update-python-deps-7-16-24

b9e86f2

Update Python dependencies - 7/16/24

another tweak for session management

3922593

ccostino added the engineering label Jul 16, 2024

ccostino requested a review from stvnrlly July 16, 2024 17:25

ccostino self-assigned this Jul 16, 2024

Merge pull request #1728 from GSA/notify-compliance-46d

2088a30

another tweak for session management

ccostino temporarily deployed to staging July 16, 2024 17:33 — with GitHub Actions Inactive

ccostino temporarily deployed to staging July 16, 2024 17:39 — with GitHub Actions Inactive

jskinne3 temporarily deployed to staging July 16, 2024 20:36 — with GitHub Actions Inactive

Specify working version, sadly the oldest version

f697572

jskinne3 temporarily deployed to staging July 16, 2024 21:20 — with GitHub Actions Inactive

Expunge boilerplate instructions, link to updated ones in API repo

b34d3c8

rahearn temporarily deployed to production July 17, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to demo July 17, 2024 12:03 — with GitHub Actions Inactive

ccostino temporarily deployed to staging July 17, 2024 21:51 — with GitHub Actions Inactive

jskinne3 temporarily deployed to staging July 17, 2024 21:54 — with GitHub Actions Inactive

jskinne3 and others added 2 commits July 17, 2024 14:54

Delete outdated Redis instance from Sandbox Terraform config

5800f92

Merge pull request #1736 from GSA/jskinne3-sandbox-remove-old-redis

7507de9

Delete outdated Redis instance from Sandbox Terraform config

ccostino temporarily deployed to demo July 17, 2024 22:02 — with GitHub Actions Inactive

ccostino temporarily deployed to production July 17, 2024 22:02 — with GitHub Actions Inactive

ccostino temporarily deployed to staging July 17, 2024 22:02 — with GitHub Actions Inactive

ccostino temporarily deployed to staging July 17, 2024 22:08 — with GitHub Actions Inactive

jskinne3 temporarily deployed to staging July 17, 2024 23:25 — with GitHub Actions Inactive

rahearn temporarily deployed to demo July 18, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to staging July 18, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to production July 18, 2024 12:03 — with GitHub Actions Inactive

stvnrlly approved these changes Jul 18, 2024

View reviewed changes

stvnrlly merged commit 0ef1af8 into production Jul 18, 2024
31 checks passed

jskinne3 temporarily deployed to staging July 18, 2024 22:53 — with GitHub Actions Inactive

rahearn temporarily deployed to staging July 19, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to production July 19, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to demo July 19, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to demo July 20, 2024 12:02 — with GitHub Actions Inactive

rahearn temporarily deployed to production July 20, 2024 12:02 — with GitHub Actions Inactive

rahearn temporarily deployed to staging July 20, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to demo July 21, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to staging July 21, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to production July 21, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to production July 22, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to staging July 22, 2024 12:03 — with GitHub Actions Inactive

rahearn temporarily deployed to demo July 22, 2024 12:03 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

07/16/2024 Production Deploy #1729

07/16/2024 Production Deploy #1729

ccostino commented Jul 16, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

07/16/2024 Production Deploy #1729

07/16/2024 Production Deploy #1729

Conversation

ccostino commented Jul 16, 2024

Description

Security Considerations

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024