Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11/14/2024 Production Deploy #2116

Merged
merged 155 commits into from
Nov 14, 2024
Merged

11/14/2024 Production Deploy #2116

merged 155 commits into from
Nov 14, 2024

Conversation

ccostino
Copy link
Contributor

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

Please enter a detailed description here.

This is a production deploy for 11/14/2024. Full release notes are here!

Security Considerations

  • All changes have been reviewed and tested prior to being included here.

ccostino and others added 14 commits November 7, 2024 14:18
This changeset fixes a typo by removing an extra E from the Login.gov sign in URL, which was causing the STATE variable to not be properly replaced with the actual state, because STATE != STATEE.

Signed-off-by: Carlo Costino <[email protected]>
…er-gets-stuck-in-a-loop

Template voiceover gets stuck in a loop #2056
This is due to recent changes in the API and an error now being thrown because the job cache cannot be properly accessed.

Signed-off-by: Carlo Costino <[email protected]>
Signed-off-by: Carlo Costino <[email protected]>
Fix Login.gov sign in URL formatting for staging
…fy_And_Expire_Redis_Stuff

Fixed email verify, put time limits on redis stuff.
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
Ok, commenting out the check for emails for now.
Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a couple comments

Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as Ken.

@ccostino ccostino merged commit 402b1d1 into production Nov 14, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants