-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11/14/2024 Production Deploy #2116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it-behind-the-log-in
…o 1999-dashboard-a11y-fixes
…it-behind-the-log-in
…it-behind-the-log-in
…o 1999-dashboard-a11y-fixes
Verify state for login.gov
This changeset fixes a typo by removing an extra E from the Login.gov sign in URL, which was causing the STATE variable to not be properly replaced with the actual state, because STATE != STATEE. Signed-off-by: Carlo Costino <[email protected]>
…er-gets-stuck-in-a-loop Template voiceover gets stuck in a loop #2056
This is due to recent changes in the API and an error now being thrown because the job cache cannot be properly accessed. Signed-off-by: Carlo Costino <[email protected]>
Signed-off-by: Carlo Costino <[email protected]>
Fix Login.gov sign in URL formatting for staging
Signed-off-by: Cliff Hill <[email protected]>
…fy_And_Expire_Redis_Stuff Fixed email verify, put time limits on redis stuff.
Signed-off-by: Cliff Hill <[email protected]>
Re-fixing the verify email step.
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
Signed-off-by: Cliff Hill <[email protected]>
Ok, commenting out the check for emails for now.
ccostino
requested review from
xlorepdarkhelm,
jonathanbobel,
stvnrlly,
terrazoon,
heyitsmebev,
A-Shumway42 and
alexjanousekGSA
November 14, 2024 17:12
terrazoon
reviewed
Nov 14, 2024
terrazoon
reviewed
Nov 14, 2024
terrazoon
reviewed
Nov 14, 2024
terrazoon
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with a couple comments
stvnrlly
approved these changes
Nov 14, 2024
xlorepdarkhelm
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as Ken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.
Description
Please enter a detailed description here.
This is a production deploy for 11/14/2024. Full release notes are here!
Security Considerations