Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production deploy 10/31/23 #891

Merged
merged 75 commits into from
Nov 1, 2023
Merged

Production deploy 10/31/23 #891

merged 75 commits into from
Nov 1, 2023

Conversation

stvnrlly
Copy link
Collaborator

@stvnrlly stvnrlly commented Oct 31, 2023 •
edited
Loading

Andrew Shumway and others added 30 commits August 16, 2023 10:55
Add initial file for popup
9d16738
Functionality for session timer display
8712d7d
Merge branch 'main' of https://github.com/GSA/notifications-admin int…
559965c 
…o notify-678
@jonathanbobel
Altered the modal a bit to use USWDS styling and the dialog element -…
1507199 
… still needs some cleanup but passing it back off to Andrew
Added user authentication check to timer
9295367
Moved html to footer
42cd3b4
@jonathanbobel
Changed a few things for accessibility
c6e356c
Refactor code/initial tests
f257a38
Create export of session timer for tests
d856e39
Merge branch 'main' of https://github.com/GSA/notifications-admin int…
9846379 
…o notify-678
Remove attempts to export module
2519011
Put timer back to 25 minute kickoff
d7e7a08
Remove unused function in test
8ab49f7
@ccostino
Made several adjustments for session timer tests
57f2ee7 
- Turned the timeoutPopup module into a proper module that is exported
- Pulled out the setInterval inner function to be its own method
- Adjusted the session timer tests to have additional setup and teardown pieces
- Added a few tests

There may be some additional adjustments needed, e.g., we may not have to expose all of the methods, but then we have to figure out how to make them accessible in the tests another way.

h/t @A-Shumway42 for pairing with me to review all of these changes and approach!

Signed-off-by: Carlo Costino <[email protected]>
Added test for code coverage
020dc87
Clean up code/tests
00db493
Separate logout by user or inactivity
93ac55c
Put timer back to 25 minutes
efce22b
@dependabot
Bump moto from 4.2.4 to 4.2.5
cd508c0 
Bumps [moto](https://github.com/getmoto/moto) from 4.2.4 to 4.2.5.
- [Release notes](https://github.com/getmoto/moto/releases)
- [Changelog](https://github.com/getmoto/moto/blob/master/CHANGELOG.md)
- [Commits](getmoto/moto@4.2.4...4.2.5)

---
updated-dependencies:
- dependency-name: moto
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Merge branch 'main' of https://github.com/GSA/notifications-admin int…
643e1ef 
…o notify-678
@jonathanbobel
822 - restrict international message services
afe6e9c
@jonathanbobel
814 - Adding alert component to CSV error area
fd196c6
@jonathanbobel
Decided not to use the template and include the USWDS alert one-by-one
af2da54
@ccostino
Merge pull request #849 from GSA/814-error-message-CSV
3a4e388 
814 error message csv
@ccostino
Merge pull request #846 from GSA/822-restrict-international-message-s…
124d342 
…ervice

822 - restrict international message services
@ccostino
Merge pull request #841 from GSA/dependabot/pip/moto-4.2.5
f1cdb79 
Bump moto from 4.2.4 to 4.2.5
@dependabot
Bump coverage from 7.3.1 to 7.3.2
d34249f 
Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.3.1 to 7.3.2.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.3.1...7.3.2)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@ccostino
Merge pull request #840 from GSA/dependabot/pip/coverage-7.3.2
9e47062 
Bump coverage from 7.3.1 to 7.3.2
@jonathanbobel
816 - Change "Prepare to send" button text
57ec11d
@ccostino
Merge pull request #850 from GSA/816-change-prepare-to-send-button
4c833a4 
816 - Change "Prepare to send" button text
dependabot bot and others added 11 commits October 16, 2023 23:16
@dependabot
Bump moto from 4.2.5 to 4.2.6
1c75f9a 
Bumps [moto](https://github.com/getmoto/moto) from 4.2.5 to 4.2.6.
- [Release notes](https://github.com/getmoto/moto/releases)
- [Changelog](https://github.com/getmoto/moto/blob/master/CHANGELOG.md)
- [Commits](getmoto/moto@4.2.5...4.2.6)

---
updated-dependencies:
- dependency-name: moto
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@ccostino
Merge pull request #868 from GSA/dependabot/pip/moto-4.2.6
962fce3 
Bump moto from 4.2.5 to 4.2.6
Uncomment existing gtm script
2c51218
@dependabot
Bump urllib3 from 1.26.17 to 1.26.18
588245f 
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.17 to 1.26.18.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.17...1.26.18)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@ccostino
Merge pull request #875 from GSA/dependabot/pip/urllib3-1.26.18
df3cdaf 
Bump urllib3 from 1.26.17 to 1.26.18
@stvnrlly
Merge pull request #872 from GSA/notify-843
f31a78c 
Uncomment existing gtm script
@ccostino
Updated dependencies and add make command
88f0715 
This changeset updates several dependencies to address security audit findings and also adds a py-lock make command to make managing our Python dependencies more manageable.

Signed-off-by: Carlo Costino <[email protected]>
@ccostino
More dependency updates
a542fa9 
Signed-off-by: Carlo Costino <[email protected]>
@ccostino
Fixed flask-login version
d9c0c75 
Signed-off-by: Carlo Costino <[email protected]>
@ccostino
Added instructions to the README
e055318 
Signed-off-by: Carlo Costino <[email protected]>
@stvnrlly
Merge pull request #890 from GSA/update-deps
fb3c9f4 
Updated dependencies and add make command
@stvnrlly stvnrlly requested a review from ccostino October 31, 2023 15:49
ccostino
ccostino previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stvnrlly and @tdlowden!

@stvnrlly stvnrlly requested a review from tdlowden October 31, 2023 17:05
@tdlowden
Copy link
Member

tdlowden commented Oct 31, 2023 •
edited
Loading

Manual QA Checklist

Log-in

  • notify-staging.app.cloud.gov resolves
  • Clicking sign in takes you to login page
  • 2FA code is sent promptly
  • 2FA code input screen appears as expected
  • After code is entered, you are brought to the “choose service” screen
  • Choosing a service brings you to the dashboard for that service

Create a template and send

  • Clicking “Send messages” brings you to templates page
  • When “Create a template” button is clicked, the option to create new or copy existing template appears
  • Uploading a csv is quick and automatically directs you to the preview/send page
  • Formatting looks clean and in place
  • Message dashboard populates and shows “pending” until call is made to AWS for delivery receipt

Send a message from copied template

  • When “Create a template” button is clicked, the option to create new or copy existing template appears
  • Clicking “copy an existing template” allows you to choose from pre-existing template
  • After editing, the new template saves and you prepare to send

Send a message from existing template

  • Clicking on existing template brings you to preview screen with prepare to send button
  • All else above persists as true (formatting, send, dashboard, etc)

Download the csv delivery report

  • Clicking on the csv download directly after a message send downloads a report that contains the data we expect
  • Clicking on the csv download link from the 7-day aggregated dashboard downloads a report that contains the data we expect

Invite a team member

  • Clicking on “Team Members” in left nav brings you to team member screen
  • Clicking “Invite a team member” brings you to email and permissions screen
  • Clicking invite team member sends an invite and shows confirmation
  • Invite email provides live link that works to register new team member

Delete a team member

  • From team member screen, clicking “Change Details” on a specific profile brings you to that person’s profile
  • Clicking on “Remove this team member” prompts a confirmation
  • Clicking the confirmation removes the team member

Sign out

  • Hitting “Sign Out” takes you back to the homepage and logs you out

@rahearn rahearn temporarily deployed to staging November 1, 2023 12:03 — with GitHub Actions Inactive
@rahearn rahearn temporarily deployed to production November 1, 2023 12:03 — with GitHub Actions Inactive
@rahearn rahearn temporarily deployed to demo November 1, 2023 12:03 — with GitHub Actions Inactive
@ccostino
Update more dependencies and fix notifications-utils
09c4dd2 
This changeset updates a few more dependencies and addresses the challenges we have had in keeping the notifications-utils dependency up-to-date.  The changes include instructions on what to do going forward for future notifications-utils updates.

Signed-off-by: Carlo Costino <[email protected]>
tdlowden
tdlowden previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@tdlowden tdlowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA script completed after snafu with GSA email yesterday.

@stvnrlly
Merge pull request #896 from GSA/fix-deps
4a98080 
Update more dependencies and fix notifications-utils
@stvnrlly stvnrlly dismissed stale reviews from tdlowden and ccostino via 4a98080 November 1, 2023 16:56
@stvnrlly stvnrlly temporarily deployed to staging November 1, 2023 16:56 — with GitHub Actions Inactive
@stvnrlly stvnrlly temporarily deployed to staging November 1, 2023 17:01 — with GitHub Actions Inactive
ccostino
ccostino approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again.

@stvnrlly stvnrlly merged commit cf2dbfc into production Nov 1, 2023
8 checks passed
@rahearn rahearn temporarily deployed to staging November 2, 2023 12:02 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccostino ccostino ccostino approved these changes

@tdlowden tdlowden tdlowden left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stvnrlly @tdlowden @ccostino @rahearn @jonathanbobel