Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expiration to redis #1500

Merged
merged 2 commits into from
Dec 30, 2024
Merged

add expiration to redis #1500

merged 2 commits into from
Dec 30, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Dec 23, 2024

Description

Search through code, find any remaining instances of redis_store.set() do not have expiration times, and fix.

Security Considerations

N/A

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@terrazoon terrazoon requested a review from a team December 23, 2024 20:51
Copy link
Contributor

@heyitsmebev heyitsmebev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heyitsmebev heyitsmebev merged commit 5f0dd6a into main Dec 30, 2024
7 checks passed
@heyitsmebev heyitsmebev deleted the notify-api-1468 branch December 30, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix remaining Redis inserts to ensure they have a TTL (expiration)
3 participants