Add message parts column to notifications table #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 21, 2024 11:38
…csv-fragmentcount
…password in our app
|
@A-Shumway42 this is the PR you've been working on recently, correct? If so, what piece(s) are still outstanding and would @terrazoon or @xlorepdarkhelm be able to pair more with you to help get this to done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are adding message parts to the notifications table and retrieving the sum of the batch based off job_id to pass to the front end and let the user know how many message parts they will use in the send.
This PR is associated with GSA/notifications-admin#1561 , which is trying to make the call for the message parts.
TODO (optional)
Fix broken tests.
Security Considerations
We previously removed PII from the db in regards to personalisation. There is a part in the logic where we add the personalisation back in but remove the users phone number and email address.