Merge pull request #1061 from GSA/1058-resolve-skipped-heading-level

1058 resolve skipped heading level
GSA · Mar 14, 2024 · d81df1c · d81df1c
2 parents b6387cd + 3c7601a
commit d81df1c
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 37 deletions.
diff --git a/benefit-finder/src/App/__tests__/__snapshots__/index.spec.jsx.snap b/benefit-finder/src/App/__tests__/__snapshots__/index.spec.jsx.snap
@@ -306,15 +306,16 @@ exports[`loads window query scenario 1 1`] = `
             >
               Results
             </h2>
-            <div
-              class="bf-result-view-description"
+            <h3
+              aria-level="3"
+              class="bf-result-view-description font-family-sans"
+              id=""
+              role="heading"
             >
-              <div>
-                <strong>
-                  You may be eligible for these benefits:
-                </strong>
-              </div>
-            </div>
+              <strong>
+                You may be eligible for these benefits:
+              </strong>
+            </h3>
             <div
               class="bf-result-view-benefits"
             >
@@ -6262,15 +6263,16 @@ exports[`loads window query scenario 2 1`] = `
             >
               Results
             </h2>
-            <div
-              class="bf-result-view-description"
+            <h3
+              aria-level="3"
+              class="bf-result-view-description font-family-sans"
+              id=""
+              role="heading"
             >
-              <div>
-                <strong>
-                  You may be eligible for these benefits:
-                </strong>
-              </div>
-            </div>
+              <strong>
+                You may be eligible for these benefits:
+              </strong>
+            </h3>
             <div
               class="bf-result-view-benefits"
             >

diff --git a/benefit-finder/src/shared/components/ResultsView/__tests__/__snapshots__/index.spec.jsx.snap b/benefit-finder/src/shared/components/ResultsView/__tests__/__snapshots__/index.spec.jsx.snap
@@ -58,15 +58,16 @@ exports[`loads view 1`] = `
           >
             Results
           </h2>
-          <div
-            class="bf-result-view-description"
+          <h3
+            aria-level="3"
+            class="bf-result-view-description font-family-sans"
+            id=""
+            role="heading"
           >
-            <div>
-              <strong>
-                You may be eligible for these benefits:
-              </strong>
-            </div>
-          </div>
+            <strong>
+              You may be eligible for these benefits:
+            </strong>
+          </h3>
           <div
             class="bf-result-view-benefits"
           >
@@ -239,15 +240,16 @@ exports[`scenario 1 loads in view with the correct amount of likely eligible ite
           >
             Results
           </h2>
-          <div
-            class="bf-result-view-description"
+          <h3
+            aria-level="3"
+            class="bf-result-view-description font-family-sans"
+            id=""
+            role="heading"
           >
-            <div>
-              <strong>
-                You may be eligible for these benefits:
-              </strong>
-            </div>
-          </div>
+            <strong>
+              You may be eligible for these benefits:
+            </strong>
+          </h3>
           <div
             class="bf-result-view-benefits"
           >

diff --git a/benefit-finder/src/shared/components/ResultsView/index.jsx b/benefit-finder/src/shared/components/ResultsView/index.jsx
@@ -94,8 +94,9 @@ const ResultsView = ({
           <Heading className="bf-result-view-heading" headingLevel={2}>
             {notQualifiedView ? notQualified.heading : qualified.heading}
           </Heading>
-          <div
+          <Heading
             className="bf-result-view-description"
+            headingLevel={3}
             dangerouslySetInnerHTML={
               notQualifiedView
                 ? createMarkup(notQualified.description)

diff --git a/benefit-finder/src/shared/locales/en/en.json b/benefit-finder/src/shared/locales/en/en.json
@@ -79,15 +79,15 @@
         "description": "<div><p>Visit each agency to find true eligibility and to apply. Check with your city, state, or employer for other benefits.</p></div>"
       },
       "heading": "Results",
-      "description": "<div><strong>You may be eligible for these benefits:</strong></div>"
+      "description": "<strong>You may be eligible for these benefits:</strong>"
     },
     "notQualified": {
       "chevron": {
         "heading": "Benefits you did not qualify for",
         "description": "According to your answers you are not eligible for these benefits."
       },
       "heading": "Results",
-      "description": "<div><strong>Based on your answers you are not eligible for these benefits.</strong>You may become eligible if you enter additional information or your situation changes.</div>"
+      "description": "<strong>Based on your answers you are not eligible for these benefits.</strong>You may become eligible if you enter additional information or your situation changes."
     },
     "stepBackLink": "Back",
     "eligibleResults": {

diff --git a/benefit-finder/src/shared/locales/es/es.json b/benefit-finder/src/shared/locales/es/es.json
@@ -79,15 +79,15 @@
         "description": "<div><p>Visite la página de cada agencia para verificar los requisitos y aplicar. Para conocer otros beneficios, consulte a su ciudad, estado, o trabajo.</p></div>"
       },
       "heading": "Resultados",
-      "description": "<div><strong>Podría ser elegible para estos beneficios:<strong/></div>"
+      "description": "<strong>Podría ser elegible para estos beneficios:<strong/>"
     },
     "notQualified": {
       "chevron": {
         "heading": "Beneficios a los que no calificó",
         "description": "Según sus respuestas usted no es elegible para estos beneficios."
       },
       "heading": "Resultados",
-      "description": "<div><strong>Según sus respuestas no es elegible para estos beneficios.<strong/> Podría calificar si tiene información adicional o si su situación cambia.</div>"
+      "description": "<strong>Según sus respuestas no es elegible para estos beneficios.<strong/> Podría calificar si tiene información adicional o si su situación cambia."
     },
     "stepBackLink": "Volver",
     "eligibleResults": {