PXBF-1567-data-attributes-in-selectors: 1567 data attributes in selectors #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com:GSA/px-benefit-finder into 1567-data-attributes-in-selectors
…dions are present
scottqueen-bixal
requested changes
Sep 10, 2024
…com:GSA/px-benefit-finder into 1567-data-attributes-in-selectors
4 tasks
…butes-selectors-updated
Remove duplicate test id locator
…com:GSA/px-benefit-finder into 1567-data-attributes-in-selectors
…ttributes-in-selectors of github.com:GSA/px-benefit-finder into 1567-data-attributes-selectors-updated
…ttributes-selectors-updated of github.com:GSA/px-benefit-finder into 1567-data-attributes-selectors-updated
1567 data attributes selectors updated
scottqueen-bixal
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR modifies the existing Cypress test automation suite to use data attributes. This will help isolate the tests from potential CSS and JavaScript changes.
Related Github Issue
Detailed Testing steps
cd benefit findernpm run dev:storybooknpm run cy:runand verify all test pass