Handle logging of ISBRH exceptions and multiple exception types #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchej123
requested review from
mitchej123,
eigenraven,
embeddedt and
ah-OOG-ah
eigenraven
approved these changes
Oct 21, 2024
embeddedt
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some logging(and caching, so that we only log unique errors, and don't constantly log the same error all the time) to record some basic information about the ISBRH/Block that threw the exception, as well as log the stack trace of the exception.
It also adds handling multiple exception types, at the moment is does the original NPE handling, but also handles AIOOB exceptions now. A different colored error block is rendered based on the exception type.