Implemented zoom functionality #721
Conversation
There was a problem hiding this comment.
jfc
proper one would be "Przybliżenie"
| if (zoom) { | ||
| // Adjust zoom level with mouse wheel while holding zoom key | ||
| int dWheel = Mouse.getDWheel(); | ||
| if (dWheel != 0) { |
There was a problem hiding this comment.
This entire if can be replaced with zoomamt -= Integer.signum(dWheel);
| import org.lwjgl.input.Keyboard; | ||
| import org.lwjgl.input.Mouse; | ||
|
|
||
| @Mod(modid = "skidzoom", name = "SkidZoom", version = "1.0") |
There was a problem hiding this comment.
please don't create another mod, just hook it up to angelica
| private int zoomamt = -7; | ||
|
|
||
| @Mod.EventHandler | ||
| public void init(FMLInitializationEvent event) { |
There was a problem hiding this comment.
only register stuff on the client
| @@ -530,7 +530,13 @@ public enum Mixins { | |||
| .addMixinClasses("mcpatcherforge.ctm_cc.MixinTextureMap") | |||
| ), | |||
| //End from NotFine | |||
|
|
|||
| //SkidZoom | |||
| SKIDZOOM(new Builder("zoom zoom") | |||
There was a problem hiding this comment.
please remove all the word "skid" that you put everywhere, it means "stealing code" and that is not appropriate
There was a problem hiding this comment.
I'm sorry I just seen all these. I'm not super familiar with the way that pull requests work and stuff so I missed all of these my apologies. And as for the word skid, its a copy pasta implementation of a mod I made for myself a while ago that was also called SkidZoom so I apologize for not seeing these messages, that is all. I will turn on notifications for any potential future pull requests.
|
|
||
| //SkidZoom | ||
| SKIDZOOM(new Builder("zoom zoom") | ||
| .setSide(Side.CLIENT).setPhase(Phase.LATE) |
There was a problem hiding this comment.
if it's vanilla it should be Phase.EARLY
| @Mod(modid = "skidzoom", name = "SkidZoom", version = "1.0") | ||
| public class SkidZoom { | ||
|
|
||
| public KeyBinding zoomKey; |
|
|
||
| @Mixin(InventoryPlayer.class) | ||
| public abstract class InventoryPlayerMixin { | ||
| @Inject(method = "changeCurrentItem", at = @At("HEAD"), cancellable = true) |
There was a problem hiding this comment.
I would prefer that you wrap the int i = Mouse.getEventDWheel(); line in the Minecraft.runTick() method and make it return 0 when it's zooming
| public class SkidZoom { | ||
|
|
||
| public KeyBinding zoomKey; | ||
| private static boolean zoom; |
There was a problem hiding this comment.
why is one field static and not the 2 others
|
|
||
| @SubscribeEvent | ||
| public void ZoomyZoomZoom(FOVUpdateEvent e) { | ||
| if (zoomKey.getIsKeyPressed() || zoomKey.isPressed()) { |
There was a problem hiding this comment.
don't use isPressed(), only use getIsKeyPressed()
| public void ZoomyZoomZoom(FOVUpdateEvent e) { | ||
| if (zoomKey.getIsKeyPressed() || zoomKey.isPressed()) { | ||
| zoom = true; | ||
| if (zoom) { |
There was a problem hiding this comment.
zoom = true followed by if(zoom) is this thing made by chat GPT ? and then you make us review it ?
There was a problem hiding this comment.
also your implementation is broken, it will stayed zoomed for a bit if you unpress the key because the even you hook into isn't fired for every frame. You need to mixin into the rendering loop and modify the FOV in there
Also you should add a setting to have a "smooth zoom" and "instant zoom"
|
I'm gonna do my own |
An OptiFine replacement needs to replace the zoom feature too.