Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charging bus for Tree Growth Simulator #3225

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

evgengoldwar
Copy link
Contributor

@evgengoldwar evgengoldwar commented Sep 18, 2024

Charging Bus - Charges tools with extra energy
image

Recipe
image

@Dream-Master Dream-Master requested a review from a team September 18, 2024 15:19
@Dream-Master Dream-Master added the new feature Add something new. Please explain in detail how it works. label Sep 18, 2024
@S4mpsa
Copy link
Contributor

S4mpsa commented Sep 18, 2024

What does it do? With the information we have here, it's a casing with a new texture. (One could look at the code, but pull requests should detail what they add to the pack, especially for new features)

Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this defacto removes the tool mechanic from tgs. not a good plan.

@chochem chochem added Affects Balance Change affecting balance. Requires admin approval before merging. ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. labels Sep 18, 2024
@LazyFleshWasTaken
Copy link

I'd put this farther than iv, maybe zpm/uv

This would completely invalidate the charging mechanic, which means the best bonus will be given forever.
A bypass like the turbine housing in UV for dura/charge should be gated in a farther tier than the multiblock.

Or, if you want to tier it to iv/luv, you could make it give a penalty.

@evgengoldwar
Copy link
Contributor Author

I'd put this farther than iv, maybe zpm/uv

This would completely invalidate the charging mechanic, which means the best bonus will be given forever. A bypass like the turbine housing in UV for dura/charge should be gated in a farther tier than the multiblock.

Or, if you want to tier it to iv/luv, you could make it give a penalty.

Yea better change the recipe to zpm.

@evgengoldwar
Copy link
Contributor Author

this defacto removes the tool mechanic from tgs. not a good plan.

Changed recipe from iv to zmp

@chochem chochem dismissed their stale review September 18, 2024 18:58

that already makes much more sense yea. please also add more description like in the top post like sampsa asked.

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Sep 18, 2024
@Dream-Master Dream-Master requested a review from a team September 18, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Change affecting balance. Requires admin approval before merging. new feature Add something new. Please explain in detail how it works.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants