-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT++ Code Sanitize #3235
GT++ Code Sanitize #3235
Conversation
Fix texture path string sorcery Add qft folder for casings Remove redundant canCreatureSpawn calls Remove redundant brackets Replace global variable that gets called once with return value Remove always true conditions Remove repeated texture side variables (block has the same texture for all sides) handItem instanceof ItemFluidContainer is always false catch (Throwable ignored) Math.max call to simplify Convert field to local variable quantityDropped and canDropFromExplosion never used redundant null casting getBlockTypeMeta, getUnlocalizedBlockName, GetProperName and getRenderColor never used aTool never used
@BlueHero233 can you add some ingame screens with the new textures here?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side note, what's up with the changed textures for QFT casings?
src/main/java/gtPlusPlus/core/block/machine/BlockPestKiller.java
Outdated
Show resolved
Hide resolved
src/main/java/gtPlusPlus/core/block/machine/BlockPestKiller.java
Outdated
Show resolved
Hide resolved
src/main/java/gtPlusPlus/core/block/machine/BlockProjectTable.java
Outdated
Show resolved
Hide resolved
src/main/java/gtPlusPlus/core/item/base/itemblock/ItemBlockGtBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/gtPlusPlus/core/item/base/itemblock/ItemBlockGtBlock.java
Outdated
Show resolved
Hide resolved
No changes, just moved them all to a "qft" folder |
Did some code cleanup before i change any textures and their references, this time i tested it on nightly 651