Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GT++ ASM Cleanup #3238

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

GT++ ASM Cleanup #3238

wants to merge 14 commits into from
+137 −1,689

Conversation

Alexdoru
Copy link
Member

@Alexdoru Alexdoru commented Sep 21, 2024 •
edited
Loading

See commit history

Deleting the ASM keyboard out of bound fix because :

  • it's trying to transform a lwjgl class that's under transformer exclusion protection so it will never work
  • it's transforming a vanilla class but doesn't respect obfuscation so it doesn't do anything lol
  • it's a vanilla bug fix so I'm making a fix in Hodgepodge

I also delete the ItemWispEssence asm fix and moved it to hodgepodge

Delete the cofh ore dict asm and move it the a mixin in hodgepodge

Delete the forge ore dict asm since it injects a null check that already exists in the base code

See GTNewHorizons/Hodgepodge#423

@Alexdoru Alexdoru added enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. bug fix Fix a bug. Please link it in the PR. refactor For PRs rewritting a part of the code to have a nicer code overall. labels Sep 21, 2024
@Alexdoru Alexdoru mentioned this pull request Sep 21, 2024
Merged
@Alexdoru Alexdoru marked this pull request as ready for review September 21, 2024 17:06
@Alexdoru Alexdoru requested a review from a team September 21, 2024 17:06
@Alexdoru Alexdoru changed the title ASM Cleanup GT++ ASM Cleanup Sep 21, 2024
@Dream-Master Dream-Master enabled auto-merge (squash) September 21, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchej123 mitchej123 mitchej123 approved these changes

Assignees
No one assigned
Labels
bug fix Fix a bug. Please link it in the PR. enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexdoru @mitchej123 @Dream-Master