Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ore Dictionary Tags for Subatomic Particles #3465

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

Nockyx
Copy link
Contributor

@Nockyx Nockyx commented Nov 8, 2024

Closes #17875

This PR adds Oredict preffixes for the Subatomic Particles acquired in the Cyclotron.

This can allow easier and better storage management of these particles which might be useful in possible automation setups of some challenge using these particles get to exist. Specially in cases like Hydrogen íons where they have different NBT regarding their charge state.

image
image
Hydrogen íons of different charge states.

image
image
image

@BlueHero233 BlueHero233 added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Nov 8, 2024
Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't really make use of the oreprefixes besides just oredict, but still a fine way of doing it I would say. We might decide to do more with this at a later point.

@chochem chochem added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 8, 2024
@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 9, 2024
@Dream-Master Dream-Master enabled auto-merge (squash) November 9, 2024 17:22
@Dream-Master Dream-Master merged commit 269ac07 into GTNewHorizons:master Nov 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ore Dictionary Tags to Subatomic Particles
4 participants