Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Waila info for ME output hatches/busses #3467

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RecursivePineapple
Copy link
Contributor

@RecursivePineapple RecursivePineapple commented Nov 8, 2024

I copied the code from the data scanner and modified it a bit to make it HUD-friendly. The data scanner output is still useful because it doesn't crop the number of stacks shown, while this crops it to 10 stacks at most.

2024-11-08_17 01 16
2024-11-08_17 01 21

@RecursivePineapple RecursivePineapple added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Nov 8, 2024
@RecursivePineapple RecursivePineapple requested a review from a team November 8, 2024 22:05

if (stackCount == 0) {
ss.add("This bus has no cached stacks");
} else {
Copy link
Contributor

@OneEyeMaker OneEyeMaker Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be very nice to not throw all this information at player immediately: only when player requests it.
Look at alveary from Forestry: one displays info about bee (large block of data) only when shift key is pressed (https://github.com/GTNewHorizons/WAILAPlugins/blob/master/src/main/java/tterrag/wailaplugins/plugins/PluginForestry.java#L252).
I suggest using similar approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants