Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blackhole fixes #3470

Merged
merged 5 commits into from
Nov 9, 2024
Merged

Blackhole fixes #3470

merged 5 commits into from
Nov 9, 2024

Conversation

FourIsTheNumber
Copy link
Contributor

@FourIsTheNumber FourIsTheNumber commented Nov 9, 2024 •
edited
Loading

  • Refactor the code for using seeds/collapsers so that it does not do shenanigans with stocking input buses
  • Prevent unnecessary code from running on client thread to fix syncing issues
  • Move catalyst check to setupProcessingLogic so that it doesn't pointlessly run multiple times per recipe check

Fixes: GTNewHorizons/GT-New-Horizons-Modpack#17912
Fixes: GTNewHorizons/GT-New-Horizons-Modpack#17910
Hopefully also fixes an undiagnosed bug that caused black hole to (rarely) perform recipes without consuming inputs from stocking buses.

@FourIsTheNumber FourIsTheNumber added the bug fix Fix a bug. Please link it in the PR. label Nov 9, 2024
@serenibyss serenibyss added bug fix Fix a bug. Please link it in the PR. and removed bug fix Fix a bug. Please link it in the PR. labels Nov 9, 2024
@serenibyss serenibyss enabled auto-merge (squash) November 9, 2024 17:29
@serenibyss serenibyss merged commit d68b5f2 into master Nov 9, 2024
5 of 7 checks passed
@serenibyss serenibyss deleted the blackhole-fixes branch November 9, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss approved these changes

Assignees
No one assigned
Labels
bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Milestone
No milestone
2 participants
@FourIsTheNumber @serenibyss