Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge working parts of fastload #434

Merged
merged 7 commits into from
Nov 10, 2024
Merged

Merge working parts of fastload #434

merged 7 commits into from
Nov 10, 2024

Conversation

ah-OOG-ah
Copy link
Member

Actually multithreading chunks is taking far longer than expected, and fastload has much easier components to merge. Both are off by default, as they may break other mods and especially hybrid servers.

  • Fast chunk handling: removes the hard caps of 5 chunks sent per player per tick and 100 chunks unloaded per tick, both are now configurable.
  • Fast int cache: rewrite's vanilla's int cache method used it chunk generation to make it threadsafe, faster, and probably less allocation-heavy. Impact will likely be minor until the rest of fastload hits (and without explicit compat it might be worse, so it'll stay off by default until then).

This does *not* pull in False's edits yet, I'm waiting on approval first rather than sorting it out later. Much cleaner.
Probably not super needed, but might as well
There's no reason to go lower than vanilla for these.
@Dream-Master Dream-Master requested review from mitchej123, Alexdoru and a team November 7, 2024 22:45
@mitchej123 mitchej123 enabled auto-merge (squash) November 10, 2024 21:48
@mitchej123 mitchej123 merged commit 08610bc into master Nov 10, 2024
1 check passed
@mitchej123 mitchej123 deleted the temper-temper branch November 10, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants